Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detection engine] refactors lists legacy templates/ILM API calls in Serverless env. #164844

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Aug 25, 2023

Summary

  • moved deletion of legacy index template inside to migrateListIndexToDataStream and migrateListToDataStream. That would allow us not to rely on 410 error to tell if we are in Serverless environment and _template API is blocked. Migrate to DS function is called only in Stateful environment, as lists indices do not exist in Serverless
  • deletion of legacy index template during migration has also other benefit: it will be called eventually for every instance of Kibana, and be more efficient then just calling it during index creation

@vitaliidm vitaliidm self-assigned this Aug 25, 2023
@vitaliidm vitaliidm added v8.11.0 refactoring Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Aug 25, 2023
@vitaliidm vitaliidm marked this pull request as ready for review August 25, 2023 16:55
@vitaliidm vitaliidm requested a review from a team as a code owner August 25, 2023 16:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm changed the title [Security Solution][Detection engine] refactor lists legacy templates/ILM on serverless [Security Solution][Detection engine] refactor lists legacy templates/ILM API calls in Serverless env. Aug 25, 2023
@vitaliidm vitaliidm changed the title [Security Solution][Detection engine] refactor lists legacy templates/ILM API calls in Serverless env. [Security Solution][Detection engine] refactors lists legacy templates/ILM API calls in Serverless env. Aug 25, 2023
@vitaliidm vitaliidm added the release_note:skip Skip the PR/issue when compiling release notes label Aug 25, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

API count

id before after diff
lists 222 224 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm merged commit 116c4b8 into elastic:main Aug 30, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 30, 2023
@vitaliidm vitaliidm deleted the detection-engine/lists-refactoring branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting refactoring release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants