Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slo): Handle error during SLO resources installation #163440

Merged
merged 3 commits into from
Aug 9, 2023
Merged

fix(slo): Handle error during SLO resources installation #163440

merged 3 commits into from
Aug 9, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Aug 8, 2023

Summary

Discussion: https://elastic.slack.com/archives/C5UDAFZQU/p1691436586081469

This PR swallows any thrown error while installing the SLO resources and transforms to prevent kibana from crashing.

@kdelemme kdelemme changed the title fix(slo): error crashes kibana fix(slo): Handle error during SLO resources installation Aug 8, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme self-assigned this Aug 8, 2023
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0 labels Aug 8, 2023
@kdelemme kdelemme marked this pull request as ready for review August 8, 2023 20:08
@kdelemme kdelemme requested a review from a team as a code owner August 8, 2023 20:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

rylnd
rylnd approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kdelemme kdelemme enabled auto-merge (squash) August 9, 2023 12:10
@kdelemme kdelemme merged commit efbb046 into elastic:main Aug 9, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 9, 2023
@kdelemme kdelemme deleted the fix/slo-installation branch August 9, 2023 14:52
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
@kdelemme @bryce-b
fix(slo): Handle error during SLO resources installation (elastic#163440
39dc223 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benakansara benakansara benakansara approved these changes

@rylnd rylnd rylnd approved these changes

Assignees

@kdelemme kdelemme

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kdelemme @apmmachine @elasticmachine @kibana-ci @rylnd @benakansara @kibanamachine