[ML] Response Stream developer example: Migrate deprecated EUI components. #162454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
4 tasks
darnautov
reviewed
Jul 26, 2023
| {children} | ||
| </EuiPageContentBody> | ||
| </EuiPageContent> | ||
| <EuiPageSection style={{ maxWidth: 800, margin: '0 auto' }}>{children}</EuiPageSection> |
There was a problem hiding this comment.
Can you pass a css prop instead? And can we avoid using a magic number? I wonder if there is a variable provided by EUI for page width.
Suggested change
| <EuiPageSection style={{ maxWidth: 800, margin: '0 auto' }}>{children}</EuiPageSection> | |
| <EuiPageSection css={{ maxWidth: 800, margin: '0 auto' }}>{children}</EuiPageSection> |
There was a problem hiding this comment.
Used the opportunity and migrated to EuiPageTemplate instead. That got rid of that custom css altogether and fixes the padding problem on the whole page too!
Before:
After:
|
Tested and LGTM 🎉 |
|
Added a breadcrumb to be able to navigate back to the developer examples main page in dab42ee.
|
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @walterra |
walterra
deleted the
ml-161408-migrate-deprecated-eui-components-response-stream
branch
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…ents. (elastic#162454) Migrates deprecated EUI components for the response stream developer example plugin. Adds a breadcrumb to the example to be able to navigate back to the overview page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #161408.
Migrates deprecated EUI components for the response stream developer example plugin. To run Kibana with developer examples use
yarn start --run-examples. Here's direct links to the pages that have been migrated:Checklist