Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix missing await in test making test flaky #156402

Merged
merged 2 commits into from
May 3, 2023

Conversation

criamico
Copy link
Contributor

@criamico criamico commented May 2, 2023

Closes #150607

Summary

Flaky test was re-enabled last month but was failing again. An "await" was missing and was likely causing the flakiness.

Checklist

@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label May 2, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico added v8.9.0 release_note:skip Skip the PR/issue when compiling release notes labels May 2, 2023
@criamico criamico marked this pull request as ready for review May 2, 2023 15:28
@criamico criamico requested a review from a team as a code owner May 2, 2023 15:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico
Copy link
Contributor Author

criamico commented May 2, 2023

The flakiness in this run was due to some other test in FTR. I'm re running before merging just to be sure.

@criamico
Copy link
Contributor Author

criamico commented May 2, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@criamico criamico merged commit b6fe8e1 into elastic:main May 3, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 3, 2023
@criamico criamico deleted the 150607_fix_flaky_test branch May 3, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.9.0
Projects
None yet
6 participants