Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Enable EPM failing suite #153928

Merged
merged 5 commits into from
Mar 30, 2023
Merged

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Mar 29, 2023

Closes #150607

Summary

Re-enable flaky test suit in x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx.

The flaky runner doesn't work with Jest tests, so I tested it locally several times on my local.

Checklist

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico criamico self-assigned this Mar 30, 2023
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 30, 2023
@criamico criamico marked this pull request as ready for review March 30, 2023 08:42
@criamico criamico requested a review from a team as a code owner March 30, 2023 08:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit 3f1ea16 into elastic:main Mar 30, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 30, 2023
jgowdyelastic pushed a commit to jgowdyelastic/kibana that referenced this pull request Mar 30, 2023
Closes elastic#150607

## Summary
Re-enable flaky test suit in
`x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx`.

The flaky runner doesn't work with Jest tests, so I tested it locally
several times on my local.


### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0
Projects
None yet
6 participants