From 1f5d307f5bc0571caeeec7c14d4597b8b5b6a19e Mon Sep 17 00:00:00 2001 From: "miriam.aparicio" Date: Wed, 4 Jan 2023 17:03:29 +0000 Subject: [PATCH] add unhabdled badge to sample summary --- .../error_sampler/error_sample_detail.tsx | 8 ++++++++ .../error_sampler/sample_summary.tsx | 13 +------------ 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/x-pack/plugins/apm/public/components/app/error_group_details/error_sampler/error_sample_detail.tsx b/x-pack/plugins/apm/public/components/app/error_group_details/error_sampler/error_sample_detail.tsx index 397bfa5e4c1a6..5366f467826c0 100644 --- a/x-pack/plugins/apm/public/components/app/error_group_details/error_sampler/error_sample_detail.tsx +++ b/x-pack/plugins/apm/public/components/app/error_group_details/error_sampler/error_sample_detail.tsx @@ -145,6 +145,7 @@ export function ErrorSampleDetails({ const status = error.http?.response?.status_code; const environment = error.service.environment; const serviceVersion = error.service.version; + const isUnhandled = error.error.exception?.[0].handled === false; const traceExplorerLink = router.link('/traces/explorer/waterfall', { query: { @@ -294,6 +295,13 @@ export function ErrorSampleDetails({ {serviceVersion} ) : null, + isUnhandled ? ( + + {i18n.translate('xpack.apm.errorGroupDetails.unhandledLabel', { + defaultMessage: 'Unhandled', + })} + + ) : null, ]} /> )} diff --git a/x-pack/plugins/apm/public/components/app/error_group_details/error_sampler/sample_summary.tsx b/x-pack/plugins/apm/public/components/app/error_group_details/error_sampler/sample_summary.tsx index af5bd2cc46b17..01fe2505d8b38 100644 --- a/x-pack/plugins/apm/public/components/app/error_group_details/error_sampler/sample_summary.tsx +++ b/x-pack/plugins/apm/public/components/app/error_group_details/error_sampler/sample_summary.tsx @@ -4,7 +4,7 @@ * 2.0; you may not use this file except in compliance with the Elastic License * 2.0. */ -import { EuiText, EuiSpacer, EuiCodeBlock, EuiBadge } from '@elastic/eui'; +import { EuiText, EuiSpacer, EuiCodeBlock } from '@elastic/eui'; import { i18n } from '@kbn/i18n'; import React from 'react'; import { euiStyled } from '@kbn/kibana-react-plugin/common'; @@ -24,20 +24,9 @@ export function SampleSummary({ error }: Props) { const logMessage = error.error.log?.message; const excMessage = error.error.exception?.[0].message; const culprit = error.error.culprit; - const isUnhandled = error.error.exception?.[0].handled === false; return ( <> - {isUnhandled && ( - <> - - {i18n.translate('xpack.apm.errorGroupDetails.unhandledLabel', { - defaultMessage: 'Unhandled', - })} - - - - )} {logMessage && ( <>