Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Use consistent filtering for fetching mobile data #144453

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

kpatticha
Copy link
Contributor

closes #144433

Screen.Recording.2022-11-02.at.17.25.54.mov

@kpatticha kpatticha requested a review from a team as a code owner November 2, 2022 16:29
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@kpatticha kpatticha added bug Fixes for quality problems that affect the customer experience v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 2, 2022
@@ -66,6 +68,8 @@ export function MobileFilters({
});
}

console.log('data', data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is left behind :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks

@gbamparop
Copy link
Contributor

gbamparop commented Nov 2, 2022

Can we have the same issue with the mobile filters? Because now if you filter by one (e.g. NCT), the data for the other filters will still remain the same as they depend only on service name, environment and transaction type.

@kpatticha
Copy link
Contributor Author

Can we have the same issue with the mobile filters? Because now if you filter by one (e.g. NCT), the data for the other filters will still remain the same as they depend only on service name, environment and transaction type.

I believe the mobile filters should depend on the "page"/"global" filters, like

  • environment
  • time range
  • transaction type
  • kuery
  • service name
  • etc

and not to each other. Do you think that can be confusing?

@gbamparop
Copy link
Contributor

I believe the mobile filters should depend on the "page"/"global" filters, like

I think that's what we discussed with @cauemarcondes as well

Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +34.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 103 108 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 104 110 +6
securitySolution 517 523 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit 57dce56 into elastic:main Nov 2, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Mobile inconsistency between charts and mobile filters
5 participants