-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Use consistent filtering for fetching mobile data #144453
Conversation
Pinging @elastic/apm-ui (Team:APM) |
@@ -66,6 +68,8 @@ export function MobileFilters({ | |||
}); | |||
} | |||
|
|||
console.log('data', data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is left behind :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, thanks
Can we have the same issue with the mobile filters? Because now if you filter by one (e.g. NCT), the data for the other filters will still remain the same as they depend only on service name, environment and transaction type. |
I believe the mobile filters should depend on the "page"/"global" filters, like
and not to each other. Do you think that can be confusing? |
I think that's what we discussed with @cauemarcondes as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
closes #144433
Screen.Recording.2022-11-02.at.17.25.54.mov