[Response Ops] Using data view service to fetch data views #131330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@elasticmachine merge upstream |
mikecote
approved these changes
May 4, 2022
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
ersin-erdal
approved these changes
May 6, 2022
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ymao1 |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129914
Summary
Using data view service to fetch index patterns instead of using the saved objects client directly. Previously, when using the saved objects client, we retrieved 1000 data views at a time and paginated if the total number of matching data views exceeded 1000. The data views service does not provide the ability to specify page number so functionality for this changes a bit as
loadIndexPatternswill now only return up to 1000 matching data views. Discussed with the team and we felt that this should be sufficient, especially since the data views are filtered based on user input.To Verify
Verify that selecting index pattern for Index Threshold and ES Query rule type still work as expected. Also verify that selecting index pattern for ES Index connector type works as expected.
Checklist