From 8c7853834465dd4dc757f4388fb1f7c557281d98 Mon Sep 17 00:00:00 2001 From: Zacqary Xeper Date: Wed, 26 Jan 2022 15:44:24 -0600 Subject: [PATCH 1/2] Reenable alert_create_flyout create alert test --- .../apps/triggers_actions_ui/alert_create_flyout.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts index b208826ec7aa4..7caa0cbacf8a0 100644 --- a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts +++ b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts @@ -105,8 +105,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { await testSubjects.click('test.always-firing-SelectOption'); } - // Failing: See https://github.com/elastic/kibana/issues/89397 - describe.skip('create alert', function () { + describe('create alert', function () { before(async () => { await pageObjects.common.navigateToApp('triggersActions'); await testSubjects.click('rulesTab'); From f0afd1223663e7593594dbf83d56df0fd0d39bfe Mon Sep 17 00:00:00 2001 From: Zacqary Xeper Date: Thu, 27 Jan 2022 11:31:40 -0600 Subject: [PATCH 2/2] Add rules tab reset to alert flyout test --- .../apps/triggers_actions_ui/alert_create_flyout.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts index 7caa0cbacf8a0..eaf71c107edd9 100644 --- a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts +++ b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts @@ -111,6 +111,13 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { await testSubjects.click('rulesTab'); }); + afterEach(async () => { + // Reset the Rules tab without reloading the entire page + // This is safer than trying to close the alert flyout, which may or may not be open at the end of a test + await testSubjects.click('connectorsTab'); + await testSubjects.click('rulesTab'); + }); + it('should create an alert', async () => { const alertName = generateUniqueKey(); await defineIndexThresholdAlert(alertName);