From 7256aada0cd1f31cf1d3a374dce357bf60cf82f2 Mon Sep 17 00:00:00 2001 From: Sergi Massaneda Date: Mon, 24 Jan 2022 14:25:30 +0100 Subject: [PATCH 1/2] tooltip added to OS column (#123377) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e76cedbd22fb71987b81eccb247831a858dcd82c) # Conflicts: # x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx # x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts --- .../hosts/components/hosts_table/columns.tsx | 8 +++++++- .../hosts/components/hosts_table/translations.ts | 15 +++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx b/x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx index d6c51b2bfe05e..a95f3433741e0 100644 --- a/x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx +++ b/x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx @@ -90,7 +90,13 @@ export const getHostsColumns = (): HostsTableColumns => [ }, { field: 'node.host.os.name', - name: i18n.OS, + name: ( + + <> + {i18n.OS} + + + ), truncateText: false, hideForMobile: false, sortable: false, diff --git a/x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts b/x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts index 773a052dc71d0..0354d7a2af71d 100644 --- a/x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts +++ b/x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts @@ -32,6 +32,21 @@ export const FIRST_LAST_SEEN_TOOLTIP = i18n.translate( } ); +export const HOST_RISK_TOOLTIP = i18n.translate( + 'xpack.securitySolution.hostsTable.hostRiskToolTip', + { + defaultMessage: + 'Host risk classifcation is determined by host risk score. Hosts classified as Critical or High are indicated as risky.', + } +); + +export const OS_LAST_SEEN_TOOLTIP = i18n.translate( + 'xpack.securitySolution.hostsTable.osLastSeenToolTip', + { + defaultMessage: 'Most recently observed OS', + } +); + export const OS = i18n.translate('xpack.securitySolution.hostsTable.osTitle', { defaultMessage: 'Operating system', }); From d4512b4ece93c4103ec018ec226806af1f335a5f Mon Sep 17 00:00:00 2001 From: semd Date: Mon, 24 Jan 2022 18:06:00 +0100 Subject: [PATCH 2/2] remove not needed translation --- .../public/hosts/components/hosts_table/translations.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts b/x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts index 0354d7a2af71d..10bc543d8c5de 100644 --- a/x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts +++ b/x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts @@ -32,14 +32,6 @@ export const FIRST_LAST_SEEN_TOOLTIP = i18n.translate( } ); -export const HOST_RISK_TOOLTIP = i18n.translate( - 'xpack.securitySolution.hostsTable.hostRiskToolTip', - { - defaultMessage: - 'Host risk classifcation is determined by host risk score. Hosts classified as Critical or High are indicated as risky.', - } -); - export const OS_LAST_SEEN_TOOLTIP = i18n.translate( 'xpack.securitySolution.hostsTable.osLastSeenToolTip', {