Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/crypto #120371

Merged
merged 2 commits into from
Dec 3, 2021
Merged

chore(NA): splits types from code on @kbn/crypto #120371

merged 2 commits into from
Dec 3, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 3, 2021

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Dec 3, 2021
@mistic mistic requested a review from jbudz December 3, 2021 16:22
@mistic

This comment has been minimized.

Sign in to view
@mistic mistic marked this pull request as ready for review December 3, 2021 18:26
@mistic mistic requested a review from a team as a code owner December 3, 2021 18:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jportner
jportner approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, looks good and thank you!

@mistic mistic enabled auto-merge (squash) December 3, 2021 18:38
jbudz
jbudz approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit ded75bd into elastic:main Dec 3, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 3, 2021
@mistic @kibanamachine
chore(NA): splits types from code on @kbn/crypto (elastic#120371)
5a980c8 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Dec 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 3, 2021
@kibanamachine @mistic
chore(NA): splits types from code on @kbn/crypto (#120371) (#120401)
1032009 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Tiago Costa <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@mistic @kibanamachine @TinLe
chore(NA): splits types from code on @kbn/crypto (elastic#120371)
f3412bf 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mistic @elasticmachine @kibana-ci @kibanamachine @jbudz @jportner