Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds KibanaThemeProvider to Home app #119254

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Adds KibanaThemeProvider to Home app #119254

merged 2 commits into from
Nov 22, 2021

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Nov 20, 2021 •
edited
Loading

Part of #118866.
Wraps the home app in the KibanaThemeProvider.

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Home Kibana home application release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 20, 2021
@TinaHeiligers TinaHeiligers mentioned this pull request Nov 20, 2021
Closed
@TinaHeiligers TinaHeiligers added the backport:skip This commit does not require backporting label Nov 20, 2021
@TinaHeiligers TinaHeiligers marked this pull request as ready for review November 20, 2021 02:08
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner November 20, 2021 02:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

pgayvallet
pgayvallet approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couldn't find any usage of toMountPoint, so I think the app wrapping was the only thing to do.

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers enabled auto-merge (squash) November 22, 2021 14:43
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 77.1KB 77.1KB +50.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
home 9.7KB 9.7KB +9.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit abd6e8e into elastic:main Nov 22, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@TinaHeiligers @kibanamachine @dmlemeshko
Adds KibanaThemeProvider to Home app (#119254)
e42ec37 
Co-authored-by: Kibana Machine <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@TinaHeiligers @kibanamachine @TinLe
Adds KibanaThemeProvider to Home app (elastic#119254)
dfaa08e 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Home Kibana home application release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TinaHeiligers @elasticmachine @kibana-ci @pgayvallet @kibanamachine