Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add theme$ to ManagementAppMountParams #118852

Merged
merged 4 commits into from
Nov 18, 2021
Merged

add theme$ to ManagementAppMountParams #118852

merged 4 commits into from
Nov 18, 2021

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Nov 17, 2021 •
edited
Loading

Summary

Follow-up of #117368
Required for #118866

Add a theme$ property to ManagementAppMountParams as it was done on AppMountParameters to ease the integration of <KibanaThemeProvider>

@pgayvallet pgayvallet requested a review from a team as a code owner November 17, 2021 11:19
@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Nov 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet requested a review from a team as a code owner November 17, 2021 11:32
azasypkin
azasypkin approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in Spaces management test LGTM (assuming CI/TypeCheck is happy too).

@pgayvallet
Copy link
Contributor Author

@elasticmachine merge upstream

@pgayvallet pgayvallet mentioned this pull request Nov 17, 2021
Closed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] OSS CI Group #9 / management scripted fields preview should display script results when script is valid

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
management 40 41 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
management 8.4KB 8.5KB +72.0B
Unknown metric groups

API count

id before after diff
management 40 41 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested and the core theme is available in the observable passed to the management app
Screenshot 2021-11-18 at 09 28 05

@pgayvallet pgayvallet merged commit 3ec4503 into elastic:main Nov 18, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 18, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
@pgayvallet @kibanamachine @TinLe
add theme$ to ManagementAppMountParams (elastic#118852)
7922bfd 
* add `theme$` to `ManagementAppMountParams`

* fix tests

* fix more test usages

Co-authored-by: Kibana Machine <[email protected]>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@pgayvallet @kibanamachine @dmlemeshko
add theme$ to ManagementAppMountParams (#118852)
8cd52a8 
* add `theme$` to `ManagementAppMountParams`

* fix tests

* fix more test usages

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pgayvallet @elasticmachine @kibana-ci @flash1293 @azasypkin @kibanamachine