From 5e8bd26c1cd98e088fffc9c24741e771322f2d32 Mon Sep 17 00:00:00 2001 From: Jean-Louis Leysens Date: Thu, 11 Nov 2021 12:11:39 +0100 Subject: [PATCH 1/2] added critical log level to unused reporting config --- x-pack/plugins/reporting/server/config/index.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/x-pack/plugins/reporting/server/config/index.ts b/x-pack/plugins/reporting/server/config/index.ts index fa836fd47cde3..e401bacfbcd00 100644 --- a/x-pack/plugins/reporting/server/config/index.ts +++ b/x-pack/plugins/reporting/server/config/index.ts @@ -18,10 +18,10 @@ export const config: PluginConfigDescriptor = { exposeToBrowser: { poll: true, roles: true }, schema: ConfigSchema, deprecations: ({ unused }) => [ - unused('capture.browser.chromium.maxScreenshotDimension'), // unused since 7.8 - unused('poll.jobCompletionNotifier.intervalErrorMultiplier'), // unused since 7.10 - unused('poll.jobsRefresh.intervalErrorMultiplier'), // unused since 7.10 - unused('capture.viewport'), // deprecated as unused since 7.16 + unused('capture.browser.chromium.maxScreenshotDimension', { level: 'critical' }), // unused since 7.8 + unused('poll.jobCompletionNotifier.intervalErrorMultiplier', { level: 'critical' }), // unused since 7.10 + unused('poll.jobsRefresh.intervalErrorMultiplier', { level: 'critical' }), // unused since 7.10 + unused('capture.viewport', { level: 'critical' }), // deprecated as unused since 7.16 (settings, fromPath, addDeprecation) => { const reporting = get(settings, fromPath); if (reporting?.roles?.enabled !== false) { From 9b5f93a33a4bd69af6c2026416a970a4ecacc932 Mon Sep 17 00:00:00 2001 From: Jean-Louis Leysens Date: Mon, 15 Nov 2021 17:29:05 +0100 Subject: [PATCH 2/2] use warning instead of critical --- x-pack/plugins/reporting/server/config/index.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/x-pack/plugins/reporting/server/config/index.ts b/x-pack/plugins/reporting/server/config/index.ts index e401bacfbcd00..711e930484e01 100644 --- a/x-pack/plugins/reporting/server/config/index.ts +++ b/x-pack/plugins/reporting/server/config/index.ts @@ -18,10 +18,10 @@ export const config: PluginConfigDescriptor = { exposeToBrowser: { poll: true, roles: true }, schema: ConfigSchema, deprecations: ({ unused }) => [ - unused('capture.browser.chromium.maxScreenshotDimension', { level: 'critical' }), // unused since 7.8 - unused('poll.jobCompletionNotifier.intervalErrorMultiplier', { level: 'critical' }), // unused since 7.10 - unused('poll.jobsRefresh.intervalErrorMultiplier', { level: 'critical' }), // unused since 7.10 - unused('capture.viewport', { level: 'critical' }), // deprecated as unused since 7.16 + unused('capture.browser.chromium.maxScreenshotDimension', { level: 'warning' }), // unused since 7.8 + unused('poll.jobCompletionNotifier.intervalErrorMultiplier', { level: 'warning' }), // unused since 7.10 + unused('poll.jobsRefresh.intervalErrorMultiplier', { level: 'warning' }), // unused since 7.10 + unused('capture.viewport', { level: 'warning' }), // deprecated as unused since 7.16 (settings, fromPath, addDeprecation) => { const reporting = get(settings, fromPath); if (reporting?.roles?.enabled !== false) {