From dc2513ae1081c5d8fb93251429f3e624513646f0 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Thu, 3 Jun 2021 09:52:45 -0500 Subject: [PATCH 01/38] eui to v34.1.0 --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index e0bebcaacd7ea..1e6f37f532ed3 100644 --- a/package.json +++ b/package.json @@ -103,7 +103,7 @@ "@elastic/datemath": "link:bazel-bin/packages/elastic-datemath/npm_module", "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@^8.0.0-canary.4", "@elastic/ems-client": "7.13.0", - "@elastic/eui": "33.0.0", + "@elastic/eui": "34.1.0", "@elastic/filesaver": "1.1.2", "@elastic/good": "^9.0.1-kibana3", "@elastic/maki": "6.3.0", diff --git a/yarn.lock b/yarn.lock index 032c5255130d9..b2e368ab74498 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1444,10 +1444,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@33.0.0": - version "33.0.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-33.0.0.tgz#525cf5ea6e6ab16c32bb09766e9c23806640240f" - integrity sha512-BQ6GJxKVaOF7Fm+IvH2iFeeGnepzygDr4xmmZ8PH2BEfrtkxzGP9YDpqmr/Drg5beVynJ3+72k1AEQT/JE6NTw== +"@elastic/eui@34.1.0": + version "34.1.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-34.1.0.tgz#215c642077b5946c175929772b3534353aa65bea" + integrity sha512-EBoM2j8oCwH6VWNYWzHXE619yglrQrPXtOGdZZk21Bh2/QsnvVc3F78nNzLWLzncTHYrYH7eUVUaCZW7hLT7hg== dependencies: "@types/chroma-js" "^2.0.0" "@types/lodash" "^4.14.160" From 65ced3a81699b2e228c27e3c1af47505618b2047 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Thu, 3 Jun 2021 09:53:12 -0500 Subject: [PATCH 02/38] styled-components types --- .../Waterfall/ResponsiveFlyout.tsx | 13 +++++++++++-- .../cases/public/components/create/flyout.tsx | 9 ++++++--- .../list_page/components/create_agent_policy.tsx | 9 ++++++++- .../shared/page_template/page_template.tsx | 10 +++------- .../public/cases/components/create/flyout.tsx | 8 +++++--- .../timelines/components/side_panel/index.tsx | 8 +++++--- .../step_detail/waterfall/waterfall_flyout.tsx | 8 +++++--- 7 files changed, 43 insertions(+), 22 deletions(-) diff --git a/x-pack/plugins/apm/public/components/app/transaction_details/WaterfallWithSummmary/WaterfallContainer/Waterfall/ResponsiveFlyout.tsx b/x-pack/plugins/apm/public/components/app/transaction_details/WaterfallWithSummmary/WaterfallContainer/Waterfall/ResponsiveFlyout.tsx index 8549f09bba248..752445563b417 100644 --- a/x-pack/plugins/apm/public/components/app/transaction_details/WaterfallWithSummmary/WaterfallContainer/Waterfall/ResponsiveFlyout.tsx +++ b/x-pack/plugins/apm/public/components/app/transaction_details/WaterfallWithSummmary/WaterfallContainer/Waterfall/ResponsiveFlyout.tsx @@ -5,10 +5,19 @@ * 2.0. */ +import { ReactNode } from 'react'; +import { StyledComponent } from 'styled-components'; import { EuiFlyout } from '@elastic/eui'; -import { euiStyled } from '../../../../../../../../../../src/plugins/kibana_react/common'; +import { + euiStyled, + EuiTheme, +} from '../../../../../../../../../../src/plugins/kibana_react/common'; -export const ResponsiveFlyout = euiStyled(EuiFlyout)` +export const ResponsiveFlyout: StyledComponent< + typeof EuiFlyout, + EuiTheme, + { children?: ReactNode } +> = euiStyled(EuiFlyout)` width: 100%; @media (min-width: 800px) { diff --git a/x-pack/plugins/cases/public/components/create/flyout.tsx b/x-pack/plugins/cases/public/components/create/flyout.tsx index 8ed09865e9eab..52ddc4fcf5152 100644 --- a/x-pack/plugins/cases/public/components/create/flyout.tsx +++ b/x-pack/plugins/cases/public/components/create/flyout.tsx @@ -5,8 +5,8 @@ * 2.0. */ -import React, { memo } from 'react'; -import styled from 'styled-components'; +import React, { memo, ReactNode } from 'react'; +import styled, { StyledComponent } from 'styled-components'; import { EuiFlyout, EuiFlyoutHeader, EuiTitle, EuiFlyoutBody } from '@elastic/eui'; import { FormContext } from '../create/form_context'; @@ -28,7 +28,10 @@ const Container = styled.div` `} `; -const StyledFlyout = styled(EuiFlyout)` +// TODO: EUI team follow up on complex types and styled-components `styled` +const StyledFlyout: StyledComponent = styled( + EuiFlyout +)` ${({ theme }) => ` z-index: ${theme.eui.euiZModal}; `} diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/components/create_agent_policy.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/components/create_agent_policy.tsx index 33dbbb25c5d42..7ffc2679c7fc6 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/components/create_agent_policy.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/components/create_agent_policy.tsx @@ -5,7 +5,9 @@ * 2.0. */ +import type { ReactNode } from 'react'; import React, { useState } from 'react'; +import type { StyledComponent } from 'styled-components'; import styled from 'styled-components'; import { i18n } from '@kbn/i18n'; import { FormattedMessage } from '@kbn/i18n/react'; @@ -29,7 +31,11 @@ import type { NewAgentPolicy, AgentPolicy } from '../../../../types'; import { useCapabilities, useStartServices, sendCreateAgentPolicy } from '../../../../hooks'; import { AgentPolicyForm, agentPolicyFormValidation } from '../../components'; -const FlyoutWithHigherZIndex = styled(EuiFlyout)` +const FlyoutWithHigherZIndex: StyledComponent< + typeof EuiFlyout, + {}, + { children?: ReactNode } +> = styled(EuiFlyout)` z-index: ${(props) => props.theme.eui.euiZLevel5}; `; @@ -39,6 +45,7 @@ interface Props extends EuiFlyoutProps { export const CreateAgentPolicyFlyout: React.FunctionComponent = ({ onClose, + as, ...restOfProps }) => { const { notifications } = useStartServices(); diff --git a/x-pack/plugins/observability/public/components/shared/page_template/page_template.tsx b/x-pack/plugins/observability/public/components/shared/page_template/page_template.tsx index bebcd53f8ae6c..8e86415453f90 100644 --- a/x-pack/plugins/observability/public/components/shared/page_template/page_template.tsx +++ b/x-pack/plugins/observability/public/components/shared/page_template/page_template.tsx @@ -5,7 +5,7 @@ * 2.0. */ -import { EuiSideNavItemType, ExclusiveUnion } from '@elastic/eui'; +import { EuiSideNavItemType } from '@elastic/eui'; import { i18n } from '@kbn/i18n'; import React, { useMemo } from 'react'; import { matchPath, useLocation } from 'react-router-dom'; @@ -28,12 +28,8 @@ export type WrappedPageTemplateProps = Pick< | 'pageContentProps' | 'pageHeader' | 'restrictWidth' -> & - // recreate the exclusivity of bottomBar-related props - ExclusiveUnion< - { template?: 'default' } & Pick, - { template: KibanaPageTemplateProps['template'] } - >; + | 'template' +>; export interface ObservabilityPageTemplateDependencies { currentAppId$: Observable; diff --git a/x-pack/plugins/security_solution/public/cases/components/create/flyout.tsx b/x-pack/plugins/security_solution/public/cases/components/create/flyout.tsx index 0f9f64b32bdd0..bbfe190585bb0 100644 --- a/x-pack/plugins/security_solution/public/cases/components/create/flyout.tsx +++ b/x-pack/plugins/security_solution/public/cases/components/create/flyout.tsx @@ -5,8 +5,8 @@ * 2.0. */ -import React, { memo } from 'react'; -import styled from 'styled-components'; +import React, { memo, ReactNode } from 'react'; +import styled, { StyledComponent } from 'styled-components'; import { EuiFlyout, EuiFlyoutHeader, EuiTitle, EuiFlyoutBody } from '@elastic/eui'; import * as i18n from '../../translations'; @@ -19,7 +19,9 @@ export interface CreateCaseModalProps { onSuccess: (theCase: Case) => Promise; } -const StyledFlyout = styled(EuiFlyout)` +const StyledFlyout: StyledComponent = styled( + EuiFlyout +)` ${({ theme }) => ` z-index: ${theme.eui.euiZModal}; `} diff --git a/x-pack/plugins/security_solution/public/timelines/components/side_panel/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/side_panel/index.tsx index 177cd2e5ded41..eb423dab53fac 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/side_panel/index.tsx +++ b/x-pack/plugins/security_solution/public/timelines/components/side_panel/index.tsx @@ -5,10 +5,10 @@ * 2.0. */ -import React, { useCallback, useMemo } from 'react'; +import React, { useCallback, useMemo, ReactNode } from 'react'; import { useDispatch } from 'react-redux'; import { EuiFlyout, EuiFlyoutProps } from '@elastic/eui'; -import styled from 'styled-components'; +import styled, { StyledComponent } from 'styled-components'; import { timelineActions, timelineSelectors } from '../../store/timeline'; import { timelineDefaults } from '../../store/timeline/defaults'; import { BrowserFields, DocValueFields } from '../../../common/containers/source'; @@ -18,7 +18,9 @@ import { EventDetailsPanel } from './event_details'; import { HostDetailsPanel } from './host_details'; import { NetworkDetailsPanel } from './network_details'; -const StyledEuiFlyout = styled(EuiFlyout)` +const StyledEuiFlyout: StyledComponent = styled( + EuiFlyout +)` z-index: ${({ theme }) => theme.eui.euiZLevel7}; `; diff --git a/x-pack/plugins/uptime/public/components/monitor/synthetics/step_detail/waterfall/waterfall_flyout.tsx b/x-pack/plugins/uptime/public/components/monitor/synthetics/step_detail/waterfall/waterfall_flyout.tsx index 53e6583e00cc2..372a8e62f5342 100644 --- a/x-pack/plugins/uptime/public/components/monitor/synthetics/step_detail/waterfall/waterfall_flyout.tsx +++ b/x-pack/plugins/uptime/public/components/monitor/synthetics/step_detail/waterfall/waterfall_flyout.tsx @@ -5,9 +5,9 @@ * 2.0. */ -import React, { useEffect, useRef } from 'react'; +import React, { useEffect, useRef, ReactNode } from 'react'; -import styled from 'styled-components'; +import styled, { StyledComponent } from 'styled-components'; import { EuiFlyout, @@ -49,7 +49,9 @@ export const RESPONSE_HEADERS = i18n.translate( } ); -const FlyoutContainer = styled(EuiFlyout)` +const FlyoutContainer: StyledComponent = styled( + EuiFlyout +)` z-index: ${(props) => props.theme.eui.euiZLevel5}; `; From fd3ea079bf48b8473b46cca28a5d850765a740cf Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Thu, 3 Jun 2021 11:35:50 -0500 Subject: [PATCH 03/38] src snapshot updates --- .../collapsible_nav.test.tsx.snap | 4439 ++++++++++------- .../header/__snapshots__/header.test.tsx.snap | 1061 ++-- .../flyout_service.test.tsx.snap | 4 +- .../dashboard_empty_screen.test.tsx.snap | 8 +- .../url/__snapshots__/url.test.tsx.snap | 8 +- .../warning_call_out.test.tsx.snap | 98 +- .../inspector_panel.test.tsx.snap | 1 + .../__snapshots__/intro.test.tsx.snap | 26 +- .../not_found_errors.test.tsx.snap | 160 +- 9 files changed, 3264 insertions(+), 2541 deletions(-) diff --git a/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap index 0f5efe667ec2f..da2252c846e26 100644 --- a/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap +++ b/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap @@ -360,1692 +360,2408 @@ exports[`CollapsibleNav renders links grouped by category 1`] = ` isOpen={true} onClose={[Function]} > - - - - } + - - -
-
- - - - - -
- - - - - - - - - - - -

- Recently viewed -

- - - - } - className="euiCollapsibleNavGroup euiCollapsibleNavGroup--light euiCollapsibleNavGroup--withHeading" - data-test-subj="collapsibleNavGroup-recentlyViewed" - id="mockId" - initialIsOpen={true} - isLoading={false} - isLoadingMessage={false} - onToggle={[Function]} - paddingSize="none" - > -
-
- +
+
- +
+
+
+
+
+
+
+
+
- -
- - - -
- - - - - - - -
- - -
- - - - - - - -

- Analytics -

- - - - } - className="euiCollapsibleNavGroup euiCollapsibleNavGroup--withHeading" - data-test-subj="collapsibleNavGroup-kibana" - id="mockId" - initialIsOpen={true} - isLoading={false} - isLoadingMessage={false} - onToggle={[Function]} - paddingSize="none" - > -
-
- - - -
-
- + +
+
- - - + logs + + + +
- +
- - - - - - - - - - -

- Observability -

- - - - } - className="euiCollapsibleNavGroup euiCollapsibleNavGroup--withHeading" - data-test-subj="collapsibleNavGroup-observability" - id="mockId" - initialIsOpen={true} - isLoading={false} - isLoadingMessage={false} - onToggle={[Function]} - paddingSize="none" - > -
-
- - - -
-
- + +
+
- - - + siem + + + +
- +
- - - - - - - - - - -

- Security -

- - - - } - className="euiCollapsibleNavGroup euiCollapsibleNavGroup--withHeading" - data-test-subj="collapsibleNavGroup-securitySolution" - id="mockId" - initialIsOpen={true} - isLoading={false} - isLoadingMessage={false} - onToggle={[Function]} - paddingSize="none" - > -
-
- - - -
-
- + +
+
- - - -
-
-
- -
- - - - - - - - - - -

- Management -

- - - - } - className="euiCollapsibleNavGroup euiCollapsibleNavGroup--withHeading" - data-test-subj="collapsibleNavGroup-management" - id="mockId" - initialIsOpen={true} - isLoading={false} - isLoadingMessage={false} - onToggle={[Function]} - paddingSize="none" - > -
-
- -
-
- -
-
-
- - - + monitoring + + + +
- +
- - - - -
-
- - - -
-
- - - -
+ +
+
-
    - - - - Dock navigation - - , - } - } - color="subdued" - data-test-subj="collapsible-nav-lock" - iconType="lockOpen" - label="Dock navigation" - onClick={[Function]} - size="xs" +
  • -
  • - -
    • -     + Dock navigation + + +
- +
- - + + - - + - - + + + +
+ +
+
+ + + +
+
+ +
+ + +
+ + +
+ +
+
+ + + +
+
+ +
+ + + + + +

+ Recently viewed +

+ + + + } + className="euiCollapsibleNavGroup euiCollapsibleNavGroup--light euiCollapsibleNavGroup--withHeading" + data-test-subj="collapsibleNavGroup-recentlyViewed" + id="mockId" + initialIsOpen={true} + isLoading={false} + isLoadingMessage={false} + onToggle={[Function]} + paddingSize="none" > - +
+ +
+
+ +
+
+
+ + + +
+
+
+ +
+ + + + +
+ + +
+ + + + + + + +

+ Analytics +

+ + + + } + className="euiCollapsibleNavGroup euiCollapsibleNavGroup--withHeading" + data-test-subj="collapsibleNavGroup-kibana" + id="mockId" + initialIsOpen={true} + isLoading={false} + isLoadingMessage={false} + onToggle={[Function]} + paddingSize="none" + > +
+
+ +
+
+ +
+
+
+ + + +
+
+
+ +
+
+ + + + + + + + + +

+ Observability +

+ + + + } + className="euiCollapsibleNavGroup euiCollapsibleNavGroup--withHeading" + data-test-subj="collapsibleNavGroup-observability" + id="mockId" + initialIsOpen={true} + isLoading={false} + isLoadingMessage={false} + onToggle={[Function]} + paddingSize="none" + > +
+
+ +
+
+ +
+
+
+ + + +
+
+
+ +
+
+ + + - close - - - - - - - - -
- + + + + + + +

+ Security +

+ + + + } + className="euiCollapsibleNavGroup euiCollapsibleNavGroup--withHeading" + data-test-subj="collapsibleNavGroup-securitySolution" + id="mockId" + initialIsOpen={true} + isLoading={false} + isLoadingMessage={false} + onToggle={[Function]} + paddingSize="none" + > +
+
+ +
+
+ +
+
+
+ + + +
+
+
+ +
+
+ + + + + + + + + +

+ Management +

+ + + + } + className="euiCollapsibleNavGroup euiCollapsibleNavGroup--withHeading" + data-test-subj="collapsibleNavGroup-management" + id="mockId" + initialIsOpen={true} + isLoading={false} + isLoadingMessage={false} + onToggle={[Function]} + paddingSize="none" + > +
+
+ +
+
+ +
+
+
+ + + +
+
+
+ +
+
+ + + +
+
+ + + +
+
+ + + +
+
+ +
    + + + + Dock navigation + + , + } + } + color="subdued" + data-test-subj="collapsible-nav-lock" + iconType="lockOpen" + label="Dock navigation" + onClick={[Function]} + size="xs" + > +
  • + +
    • +     +
+ +
+
+ + + + + + + + + + + `; @@ -2757,466 +3473,439 @@ exports[`CollapsibleNav renders the default nav 3`] = ` isOpen={false} onClose={[Function]} > - - -
+ -
- - - -
- - -
- + + + - -
+ + +
+ -
- +
-
    - - - - Undock navigation - - , - } - } - color="subdued" - data-test-subj="collapsible-nav-lock" - iconType="lock" - label="Undock navigation" - onClick={[Function]} - size="xs" + -
  • - , + } + } + color="subdued" data-test-subj="collapsible-nav-lock" - disabled={false} + iconType="lock" + label="Undock navigation" onClick={[Function]} - type="button" + size="xs" > - - - - - Undock navigation - - -
    • -     -
- -
-
- - -
- - - - - - - -
- + + + + + +
+ + + + + + + + + + `; diff --git a/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap index 49d2cf0f5f0f5..b0722db5cfc46 100644 --- a/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap +++ b/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap @@ -4941,661 +4941,634 @@ exports[`Header renders 1`] = ` isOpen={false} onClose={[Function]} > - - -
+ -
- - - - -
- - -
- + +
+ +
-
- - - -
+ + + + + + Home + + + + + + +
+
+ - - - - - - - -

- Recently viewed -

- - - - } - className="euiCollapsibleNavGroup euiCollapsibleNavGroup--light euiCollapsibleNavGroup--withHeading" - data-test-subj="collapsibleNavGroup-recentlyViewed" - id="mockId" - initialIsOpen={true} - isLoading={false} - isLoadingMessage={false} - onToggle={[Function]} - paddingSize="none" - > -
+ -
+ + +

+ Recently viewed +

+ + + + } + className="euiCollapsibleNavGroup euiCollapsibleNavGroup--light euiCollapsibleNavGroup--withHeading" + data-test-subj="collapsibleNavGroup-recentlyViewed" + id="mockId" + initialIsOpen={true} + isLoading={false} + isLoadingMessage={false} + onToggle={[Function]} + paddingSize="none" > -
- - - -
-
- -
-
+ + +
+
+ -
- +
- - + + + dashboard + + + + + + +
+
-
+
- - - - - - -
- - -
- + + + +
+ +
-
- -
    - -
  • - -
    • -     -
- -
-
- - - -
-
- -
    - - - Undock navigation + kibana - , - } - } - color="subdued" - data-test-subj="collapsible-nav-lock" - iconType="lock" - label="Undock navigation" - onClick={[Function]} - size="xs" + + + +
+ +
+
+ + + +
+
+ -
  • - , + } + } + color="subdued" data-test-subj="collapsible-nav-lock" - disabled={false} + iconType="lock" + label="Undock navigation" onClick={[Function]} - type="button" + size="xs" > - - - - - Undock navigation - - -
    • - - -     -
    -
    -     -     -
    -     - - - - - - - -     + + + + + + + + + + + + + + + + diff --git a/src/core/public/overlays/flyout/__snapshots__/flyout_service.test.tsx.snap b/src/core/public/overlays/flyout/__snapshots__/flyout_service.test.tsx.snap index f5a1c51ccbe15..602bb62ce36a3 100644 --- a/src/core/public/overlays/flyout/__snapshots__/flyout_service.test.tsx.snap +++ b/src/core/public/overlays/flyout/__snapshots__/flyout_service.test.tsx.snap @@ -26,7 +26,7 @@ Array [ ] `; -exports[`FlyoutService openFlyout() renders a flyout to the DOM 2`] = `"
    Flyout content
    "`; +exports[`FlyoutService openFlyout() renders a flyout to the DOM 2`] = `"
    Flyout content
    "`; exports[`FlyoutService openFlyout() with a currently active flyout replaces the current flyout with a new one 1`] = ` Array [ @@ -59,4 +59,4 @@ Array [ ] `; -exports[`FlyoutService openFlyout() with a currently active flyout replaces the current flyout with a new one 2`] = `"
    Flyout content 2
    "`; +exports[`FlyoutService openFlyout() with a currently active flyout replaces the current flyout with a new one 2`] = `"
    Flyout content 2
    "`; diff --git a/src/plugins/dashboard/public/application/embeddable/empty_screen/__snapshots__/dashboard_empty_screen.test.tsx.snap b/src/plugins/dashboard/public/application/embeddable/empty_screen/__snapshots__/dashboard_empty_screen.test.tsx.snap index 44beed5e4a89b..939077f5bb0aa 100644 --- a/src/plugins/dashboard/public/application/embeddable/empty_screen/__snapshots__/dashboard_empty_screen.test.tsx.snap +++ b/src/plugins/dashboard/public/application/embeddable/empty_screen/__snapshots__/dashboard_empty_screen.test.tsx.snap @@ -601,7 +601,7 @@ exports[`DashboardEmptyScreen renders correctly with readonly mode 1`] = ` } > -
    -
    +     @@ -946,7 +946,7 @@ exports[`DashboardEmptyScreen renders correctly with view mode 1`] = ` } > -
    -
    +     diff --git a/src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap b/src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap index 40170c39942e5..79c1a11cfef84 100644 --- a/src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap +++ b/src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap @@ -153,7 +153,7 @@ exports[`UrlFormatEditor should render normally 1`] = ` class="euiFormControlLayout__childrenWrapper" >
    -
    -

    - - - , - } - } + +

    - - For greater flexibility and Painless script support, use - + + + , + } + } > - - - . - - -

    + + + . + + +

    +
    +
    -     +
    diff --git a/src/plugins/inspector/public/ui/__snapshots__/inspector_panel.test.tsx.snap b/src/plugins/inspector/public/ui/__snapshots__/inspector_panel.test.tsx.snap index 5ad8205365146..67d2cf72c5375 100644 --- a/src/plugins/inspector/public/ui/__snapshots__/inspector_panel.test.tsx.snap +++ b/src/plugins/inspector/public/ui/__snapshots__/inspector_panel.test.tsx.snap @@ -329,6 +329,7 @@ exports[`InspectorPanel should render as expected 1`] = ` >
    -
    - +
    - Modifying objects is for advanced users only. Object properties are not validated and invalid objects could cause errors, data loss, or worse. Unless someone with intimate knowledge of the code told you to be in here, you probably shouldn’t be. - -
    +
    + + Modifying objects is for advanced users only. Object properties are not validated and invalid objects could cause errors, data loss, or worse. Unless someone with intimate knowledge of the code told you to be in here, you probably shouldn’t be. + +
    +
    +
    diff --git a/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap index bddfe000008d4..f977c17df41d3 100644 --- a/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap @@ -49,29 +49,39 @@ exports[`NotFoundErrors component renders correctly for index-pattern type 1`] =
    -
    - - The index pattern associated with this object no longer exists. - -
    -
    - +
    - If you know what this error means, go ahead and fix it — otherwise click the delete button above. - -
    +
    + + The index pattern associated with this object no longer exists. + +
    +
    + + If you know what this error means, go ahead and fix it — otherwise click the delete button above. + +
    +
    +
    @@ -128,29 +138,39 @@ exports[`NotFoundErrors component renders correctly for index-pattern-field type
    -
    - - A field associated with this object no longer exists in the index pattern. - -
    -
    - +
    - If you know what this error means, go ahead and fix it — otherwise click the delete button above. - -
    +
    + + A field associated with this object no longer exists in the index pattern. + +
    +
    + + If you know what this error means, go ahead and fix it — otherwise click the delete button above. + +
    +
    +
    @@ -207,29 +227,39 @@ exports[`NotFoundErrors component renders correctly for search type 1`] = `
    -
    - - The saved search associated with this object no longer exists. - -
    -
    - +
    - If you know what this error means, go ahead and fix it — otherwise click the delete button above. - -
    +
    + + The saved search associated with this object no longer exists. + +
    +
    + + If you know what this error means, go ahead and fix it — otherwise click the delete button above. + +
    +
    +
    @@ -286,21 +316,31 @@ exports[`NotFoundErrors component renders correctly for unknown type 1`] = `
    -
    -
    - +
    - If you know what this error means, go ahead and fix it — otherwise click the delete button above. - -
    +
    +
    + + If you know what this error means, go ahead and fix it — otherwise click the delete button above. + +
    +
    +
    From 4c3e720fcfbec2ce8989fc3c68ddfcd993abb833 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Thu, 3 Jun 2021 13:38:20 -0500 Subject: [PATCH 04/38] x-pack snapshot updates --- .../custom_element_modal.stories.storyshot | 32 +- .../datasource_component.stories.storyshot | 10 +- .../keyboard_shortcuts_doc.stories.storyshot | 9 +- .../__snapshots__/pdf_panel.stories.storyshot | 4 +- .../__snapshots__/settings.test.tsx.snap | 10 +- .../autoplay_settings.stories.storyshot | 12 +- .../toolbar_settings.stories.storyshot | 12 +- .../extend_index_management.test.tsx.snap | 142 +- .../__snapshots__/policy_table.test.tsx.snap | 4 +- .../upload_license.test.tsx.snap | 96 +- .../__snapshots__/checker_errors.test.js.snap | 54 +- .../__snapshots__/no_data.test.js.snap | 8 +- .../__snapshots__/page_loading.test.js.snap | 4 +- .../report_info_button.test.tsx.snap | 468 ++++--- .../__snapshots__/prompt_page.test.tsx.snap | 4 +- .../unauthenticated_page.test.tsx.snap | 2 +- .../reset_session_page.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 1142 +++++++++++------ .../__snapshots__/license_info.test.tsx.snap | 30 +- .../__snapshots__/expanded_row.test.tsx.snap | 82 +- 20 files changed, 1337 insertions(+), 790 deletions(-) diff --git a/x-pack/plugins/canvas/public/components/custom_element_modal/__stories__/__snapshots__/custom_element_modal.stories.storyshot b/x-pack/plugins/canvas/public/components/custom_element_modal/__stories__/__snapshots__/custom_element_modal.stories.storyshot index 18f86aca24302..dc66eef809050 100644 --- a/x-pack/plugins/canvas/public/components/custom_element_modal/__stories__/__snapshots__/custom_element_modal.stories.storyshot +++ b/x-pack/plugins/canvas/public/components/custom_element_modal/__stories__/__snapshots__/custom_element_modal.stories.storyshot @@ -80,7 +80,7 @@ exports[`Storyshots components/Elements/CustomElementModal with description 1`] className="euiFormControlLayout__childrenWrapper" >
    40 characters remaining
    @@ -119,7 +119,7 @@ exports[`Storyshots components/Elements/CustomElementModal with description 1`] className="euiFormRow__fieldWrapper" >