Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Move the core parts of the code to src/plugins #98082

Closed
3 tasks
tsullivan opened this issue Apr 22, 2021 · 5 comments
Closed
3 tasks

[Reporting] Move the core parts of the code to src/plugins #98082

tsullivan opened this issue Apr 22, 2021 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead high impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture

Comments

@tsullivan
Copy link
Member

tsullivan commented Apr 22, 2021

TBD: state clearly the goals of refactoring

Parts of Reporting are available with a Basic license. By moving parts of Reporting to src/plugins, OSS applications would be able to register their own integration points with the Reporting plugin, instead of having Reporting code provide those registrations. Doing this will simplify the Reporting plugin code. To achieve this, parts of Reporting code should move to src/plugins:

  • ReportingCore
  • ExportTypeRegistry
  • CSV ExportType definitions

Other parts of Reporting code should remain in xpack:

  • PNG export
  • PDF export
  • get_screenshots function

Depends on other parts of Kibana moving to src/plugins:

  • License plugin
  • Task Manager
  • Security plugin
@tsullivan tsullivan added the bug Fixes for quality problems that affect the customer experience label Apr 22, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 22, 2021
@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServices technical debt Improvement of the software architecture and operational architecture labels Apr 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 22, 2021
@tsullivan tsullivan changed the title [Reporting] Move the core parts of the code and Basic-license code to src/plugins [Reporting] Move the core parts of the code to src/plugins Apr 22, 2021
@tsullivan tsullivan added high impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Apr 23, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort loe:large Large Level of Effort and removed loe:small Small Level of Effort labels Apr 26, 2021
@tsullivan
Copy link
Member Author

Possibly intersects with #81762

@petrklapka petrklapka added 1 and removed 1 labels May 6, 2021
@tsullivan
Copy link
Member Author

tsullivan commented May 12, 2021

@jloleysens and I discussed this and he noted that Reporting has a dependency on Task Manager, and that stands in the way of moving any part of Reporting to src/plugins.

We also discussed the fact that there is a major part of Reporting code that has a Platinum license, and these features are connected to OSS features. Therefore, there still needs to be some kind of separate connecting piece that registers the Kibana features on behalf of OSS features. That idea goes back to the argument for an unpopular proposal I made earlier: #94995

We ended on the thought that if we can only move Basic license code to src/plugins, it undermines the argument to move Reporting to src/plugins because half the code is above Basic license.

@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Sep 29, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 7, 2021
@petrklapka petrklapka added Team:AppServicesSv Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:AppServicesUx labels Oct 24, 2022
@tsullivan
Copy link
Member Author

Pretty much all of the code within Reporting is x-pack specific. We should simplify individual parts of Reporting by breaking it up, but we don't necessarily need to move parts into src/plugins unless there is a benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead high impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

4 participants