Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY axis] Improve expression with explicit params #97247

Closed
3 tasks
stratoula opened this issue Apr 15, 2021 · 2 comments · Fixed by #98897
Closed
3 tasks

[XY axis] Improve expression with explicit params #97247

stratoula opened this issue Apr 15, 2021 · 2 comments · Fixed by #98897
Assignees
Labels
Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Apr 15, 2021

Describe the feature:
Right now the vis_type_xy is using a JSON visConfig which is not ideal for other teams to reuse it.
We should remove the JSON blob and use explicit params instead.

A good example of this is vis_data_table or vis_type_metric that they have already solved this problem and use explicit params instead of the visConfig json blob.

Acceptance criteria/testing scenarios:

  • This should only affect the xy axis plugin and not the vislib one.
  • Test backwards compatibility
  • Test that nothing has been broken as XY axis has a quite big list of params.
@stratoula stratoula added Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor Author

stratoula commented Apr 15, 2021

Same applies for vis_type_pie. I will take care of it here #83929

cc @ppisljar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants