-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Embeddable navigateToPrefilledEditor open in new tab #94555
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
@ThomThomson The Lens api uses this embeddable API under the hood: kibana/src/plugins/embeddable/public/lib/state_transfer/embeddable_state_transfer.ts Line 114 in 7994e87
It puts the params into session storage, then opens the Lens app which will read it from session storage again. This means it won't work out of the box for new tabs. We could use local storage just for the transfer (put it there for the new tab navigation, in the new tab check local storage, move it to session storage and remove it from local storage again). What do you think? |
@flash1293 that solution is definitely the one that comes to mind first, and it also seems like the right one in this circumstance. I will be very excited to see this API extended in this way! |
@ThomThomson is this something possible in near term? |
@shahzad31, unfortunately I don't believe this is currently in our roadmap for the near term. Feel free to reach out on the kibana-presentation channel and we can talk about it a little more. |
Describe the feature:
Lens provides
navigateToPrefilledEditor
for embeddable component, where user can navigate to view the visualisation in lens.It works perfectly but it should also provide an option if user wants to open lens in new tabs. It can work as link or perhaps a prop to force it to open in a new tab.
The text was updated successfully, but these errors were encountered: