-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Use of localStorage #93909
Comments
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
I believe this will be addressed in a centralized manner by the Core team via #17888. |
See #23488 for more context. That issue has a lot of likes and also some more anecdotal data. |
Also relates to #39017, which requests that Console history be space-aware. |
Pinging @elastic/kibana-management (Team:Kibana Management) |
Console uses
localStorage
to persist the current user's inputted text and last 500 requests across usage sessions. Use oflocalStorage
in this way has the following issues:Security issue
Shared between all users of the browser instance. The degree to which this is a problem depends on the sensitivity of the text stored and who has access to the computer and browser.
Storage issue
localStorage
has a quota of 10mb that is shared among all plugins on Kibana. This can lead to a situation where Console fills uplocalStorage
(e.g., #78014) and can cause issues for other plugins trying to save data there. E.g., the news feed entries:Solution
Console should migrate away from storing text in
localStorage
and instead find a more scalable solution. One approach (#56769) is to save all Console state in the ES with encrypted saved objects. The attempted solution incurred the complexity of managing secure access to stored objects, which seemed like a solution that could be required in multiple places in Kibana. Once this is figured out, it seems as though this might be the most scalable and secure way of storing user inputs with the added benefit that a user will have their Console state available no matter which browser they have logged in with.The text was updated successfully, but these errors were encountered: