Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Use of localStorage #93909

Open
jloleysens opened this issue Mar 8, 2021 · 5 comments
Open

[Console] Use of localStorage #93909

jloleysens opened this issue Mar 8, 2021 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

Console uses localStorage to persist the current user's inputted text and last 500 requests across usage sessions. Use of localStorage in this way has the following issues:

Security issue

Shared between all users of the browser instance. The degree to which this is a problem depends on the sensitivity of the text stored and who has access to the computer and browser.

Storage issue

localStorage has a quota of 10mb that is shared among all plugins on Kibana. This can lead to a situation where Console fills up localStorage (e.g., #78014) and can cause issues for other plugins trying to save data there. E.g., the news feed entries:

Screenshot 2021-03-08 at 10 26 28

Solution

Console should migrate away from storing text in localStorage and instead find a more scalable solution. One approach (#56769) is to save all Console state in the ES with encrypted saved objects. The attempted solution incurred the complexity of managing secure access to stored objects, which seemed like a solution that could be required in multiple places in Kibana. Once this is figured out, it seems as though this might be the most scalable and secure way of storing user inputs with the added benefit that a user will have their Console state available no matter which browser they have logged in with.

@jloleysens jloleysens added bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Mar 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 8, 2021

save all Console state in the ES with encrypted saved objects

I believe this will be addressed in a centralized manner by the Core team via #17888.

@cjcenizal
Copy link
Contributor

See #23488 for more context. That issue has a lot of likes and also some more anecdotal data.

@cjcenizal
Copy link
Contributor

Also relates to #39017, which requests that Console history be space-aware.

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 16, 2024
@alisonelizabeth alisonelizabeth removed bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools needs-team Issues missing a team label labels Sep 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 16, 2024
@alisonelizabeth alisonelizabeth added Feature:Console Dev Tools Console Feature enhancement New value added to drive a business result Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed needs-team Issues missing a team label labels Sep 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 17, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 17, 2024
@alisonelizabeth alisonelizabeth added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 17, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

4 participants