Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove individual polling behaviors in healthcheck #9309

Closed
epixa opened this issue Dec 1, 2016 · 1 comment
Closed

Remove individual polling behaviors in healthcheck #9309

epixa opened this issue Dec 1, 2016 · 1 comment
Labels
chore Team:Operations Team label for Operations Team

Comments

@epixa
Copy link
Contributor

epixa commented Dec 1, 2016

At the moment, each step of the healthcheck has its own polling behavior, but the healthcheck itself is also polled, so there does seem to be some unnecessary complexity here. I think the healthcheck would essentially behave the same way if we removed the individual polling and just relied on the global polling of the healthcheck.

One difference in behavior with this approach would be that every healthcheck would run every request on each poll, even when some sort of failure case was handled on the previous poll. The current behavior is to repeat only the current action until a success state for that action is encountered. It's unclear to me whether that's a problem or not, and it may even be more appropriate to repeat the whole series of checks each time anyway.

@jbudz
Copy link
Member

jbudz commented Apr 18, 2019

We're down to one, validating elasticsearch's version. I think we're good on this one for now.

Related #32428
Related #33579

@jbudz jbudz closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

2 participants