Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Results trimmed tooltip message doubles feature count for line and polygon features #92658

Closed
kindsun opened this issue Feb 24, 2021 · 7 comments · Fixed by #92932
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation regression v7.12.0 v8.0.0

Comments

@kindsun
Copy link
Contributor

kindsun commented Feb 24, 2021

Steps to produce:

  1. upload a line or polygon dataset that has more then 10000 features
  2. Add a "Documents" layer for the uploaded index and set scaling to "Limit results".
  3. Notice how the icon in the legend shows results have been trimmed. Mouse over the title in the legend to view the tooltip. The results trimmed message has double counted the features and should say 10000 instead of 20000. In the screen shot below the data set only has 10,117 features so its impossible to have 20000.

Screen Shot 2021-02-25 at 7 48 22 AM

@kindsun kindsun added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.12.0 labels Feb 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kmartastic
Copy link
Contributor

The UI option is not "dynamic" -- it always says 10k.
Is there a query setting that supersedes the UI option? Could the UI be updated to reflect the setting if yes?

@aaronjcaldwell @thomasneirynck

@nreese
Copy link
Contributor

nreese commented Feb 24, 2021

UI is dynamic and loads the value from settings.index.max_result_window

@aaronjcaldwell Can you provide more details on how to reproduce this issue. What steps did you take, what data set are you using?

@kindsun
Copy link
Contributor Author

kindsun commented Feb 24, 2021

@nreese Sure

  1. Use GeoJSON uploader to upload this file
  2. Follow through the normal layer adding process
  3. In this particular case I also re-added the layer as a document layer following the upload/add process but I belive the behavior is the same either way

@kindsun
Copy link
Contributor Author

kindsun commented Feb 24, 2021

I should also mention, there may be another minor issue worth breaking out here. This dataset indicates it's limited to the first 20k documents, but there are < 20k docs indexed.

@nreese
Copy link
Contributor

nreese commented Feb 25, 2021

This is a regression caused by labels for polygons and lines. A centroid feature is added for each line and polygon feature. Thus the feature collection of length 10000 is actually doubled in size to 20000 features. Instead of using values: { count: featureCollection.features.length }, the actual feature count should be returned in meta

@nreese nreese self-assigned this Feb 25, 2021
@nreese
Copy link
Contributor

nreese commented Feb 25, 2021

Added the following instructions to issue description

Steps to produce:

  1. upload a line or polygon dataset that has more then 10000 features
  2. Add a "Documents" layer for the uploaded index and set scaling to "Limit results".
  3. Notice how the icon in the legend shows results have been trimmed. Mouse over the title in the legend to view the tooltip. The results trimmed message has double counted the features and should say 10000 instead of 20000. In the screen shot below the data set only has 10,117 features so its impossible to have 20000.

@nreese nreese changed the title [Maps] Mismatch in limit placed on number of geo lines shown [Maps] Results trimmed tooltip message doubles feature count for line and polygon features Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation regression v7.12.0 v8.0.0
Projects
None yet
4 participants