Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] replace AppMountParameters.onAppLeave with ScopedHistory.block #92196

Open
nreese opened this issue Feb 22, 2021 · 4 comments
Open

[Maps] replace AppMountParameters.onAppLeave with ScopedHistory.block #92196

nreese opened this issue Feb 22, 2021 · 4 comments
Labels
chore Feature:Maps impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Feb 22, 2021

Part of #92187

Replace AppMountParameters.onAppLeave with ScopedHistory.block
@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Feb 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese mentioned this issue Feb 22, 2021
Open
6 tasks
@jb1b84 jb1b84 added Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Feb 23, 2023
@ThomThomson
Copy link
Contributor

@nreese does ScopedHistory.block interrupt tab closing? If so, we should probably use it on the dashboard side as well.

@nreese
Copy link
Contributor Author

nreese commented Apr 5, 2023

@nreese does ScopedHistory.block interrupt tab closing? If so, we should probably use it on the dashboard side as well.

I am not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Maps impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nreese @jb1b84 @ThomThomson @elasticmachine