Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] De-angularization of the app #91128

Closed
stratoula opened this issue Feb 11, 2021 · 5 comments
Closed

[Graph] De-angularization of the app #91128

stratoula opened this issue Feb 11, 2021 · 5 comments
Assignees
Labels
Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@stratoula
Copy link
Contributor

As angularJS will no longer be supported after 31.12.2021, we should proceed with the deangularization of the Graph app:

@stratoula stratoula added Feature:Graph Graph application feature technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor Author

It may make sense here to also remove the kui usage. It is mainly used on an angular template.

@flash1293
Copy link
Contributor

There are three things which are still managed by angular:

  • The UI of the control panel (most of the KUI usage is in there). It should be straightforward to convert it into react (there might be some questions about design)
  • The inspector menu - I guess it makes sense to move it into a flyout and use monaco to render request/response just like the dashboard inspector is doing it
  • The logic managing the graph state (positions of nodes and edges, history for undo/redo). These things should be moved into the existing redux store. Right now there are a bunch of redux sagas managing the interaction between angular and redux, most of them can probably go away. The bouncy animation is done using a d3 utility, I'm not sure whether we want to move this part into redux as well or keep it outside in a separate store which is cheaper to update in place

@timroes
Copy link
Contributor

timroes commented Jul 12, 2021

More information can be found in https://gist.github.com/flash1293/ef51b9d97a5522c802ea60e75867eb29

@kertal
Copy link
Member

kertal commented Sep 2, 2021

closed by #106587

@kertal kertal closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

6 participants