Migrate vis_type_table plugin to synchronous lifecycle #90582
Labels
discuss
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Required for #53268
In #89562, we migrated almost all plugins to synchronous lifecycle.
However, the
vis_type_table
plugin could not be migrated, because of the conditional lazy import the it is performingkibana/src/plugins/vis_type_table/public/plugin.ts
Lines 44 to 57 in 3b3327d
Note that those config-based conditional imports seems to make sense, as they reduce the initial-load bundle size. However, this is not something that is going to work with synchronous plugins, nor a use-case we really thought about.
I'm unsure what should be done here to be honest:
Seems the most pragmatic, but OTOH it just doesn't feel right.
await
s and have theregisterXXXVis
performing the registration asynchronously.Seems like an even worse option
WDYT all?
The text was updated successfully, but these errors were encountered: