Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Handle "Alert on No Data" with action groups #90062

Closed
Zacqary opened this issue Feb 2, 2021 · 9 comments
Closed

[Metrics UI] Handle "Alert on No Data" with action groups #90062

Zacqary opened this issue Feb 2, 2021 · 9 comments
Labels
Breaking Change enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Feb 2, 2021

106328499-8e06ae00-6245-11eb-8353-dbd10fe20b1c

Now that the Alerting plugin has implemented action groups, we should switch No Data alerts to their own action group instead of having them piggyback on the Fired group. This will improve compatibility with the Notify on status change setting, and be generally more idiomatic with how alerts seem to want to work.

This change could break backwards compatibility with existing No Data alerts. We should figure out a way to release it without having to wait for 8.0, either through a migration tool or by including residual code to allow the deprecated No Data alert system to still function. With 8.0 on the horizon, now is probably a good time to do this.

@Zacqary Zacqary changed the title [Metrics UI] Handle [Metrics UI] Handle "Alert on No Data" with action groups Feb 2, 2021
@Zacqary Zacqary added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary Zacqary added the enhancement New value added to drive a business result label Feb 2, 2021
@jasonrhodes jasonrhodes added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 1, 2021
@Zacqary
Copy link
Contributor Author

Zacqary commented Nov 1, 2021

This is a bigger issue than just adding an action group. It would probably require some alert-wide UX overhaul, considering:

  • The current UX of allowing No Data alerts is a simple checkbox
  • Changing this to use an action group would make more sense for the alerting system internally, but it would significantly degrade the UX of creating an alert. Alternate action groups are hidden behind the multi-step process of having to create a new action, select the appropriate group from the dropdown, etc. etc.

We also want to enable No Data alerts by default, and have the user opt-out of them to turn them off. This is easy with a checkbox. This is currently impossible with a separate action group, as we cannot programmatically define action groups by default.

@Zacqary
Copy link
Contributor Author

Zacqary commented Nov 16, 2021

@elastic/kibana-alerting-services Are y'all tracking any issues that could be related to the above comment? The UI for creating actions is blocking us on moving functionality that ought to be handled by action groups, into action groups. Like for this No Data use case — which is a behavior we'd like to be opt-out, instead of opt-in — we're blocked by the fact that:

  1. We can't configure an action for a certain action group by default
  2. Action groups are only discoverable when the user clicks 3-4 times to create a new action, open the action groups drop-down, etc.

@mikecote
Copy link
Contributor

@Zacqary I've found two issues touching the idea of no data (#67296 and #71503).

The usage of action groups for this use case makes sense. It's similar to what we've done with "recovered". The concept of opt-in by default is interesting, I'd be interested in hearing more about how # 1 would function. Regarding # 2, this may be a problem with the overall UX of action groups and could be iterated on with feedback from designers.

@smith smith added Feature:Metrics UI Metrics UI feature and removed Feature:Metrics UI Metrics UI feature labels Jun 14, 2023
@roshan-elastic
Copy link

@katrin-freihofner - Wondering if this use case fits into anything you're thinking about? Remember where users were setting insanely high metric limits as a workaround to check for no data?

Wondering if this is duplicated elsewhere and should be closed.

We're unlikely to tackle this in the near future unless there is alignment with your team.

@katrin-freihofner
Copy link
Contributor

Yes, we are thinking about a "no data" rule but it's not fully defined and there is no issue for that yet.

@roshan-elastic
Copy link

Cool - I'll close this issue as this issue won't get completed until it's a priority for your team (in which case, a new issue will be created - I'm sure we'll talk about it).

@roshan-elastic roshan-elastic closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2023
@roshan-elastic roshan-elastic reopened this Jul 3, 2023
@roshan-elastic roshan-elastic added Feature:Metrics UI Metrics UI feature and removed Feature:Metrics UI Metrics UI feature labels Jul 3, 2023
@roshan-elastic
Copy link

Actually - re-opening but I'll remove it from our backlog since it's not work we'll be initiating

@emma-raffenne
Copy link
Contributor

This ticket is old and probably deprecated, feel free to reopen it if it is still relevant and needed.

@emma-raffenne emma-raffenne closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Projects
None yet
Development

No branches or pull requests

8 participants