Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Make DEFAULT_MAX_HITS_PER_EXECUTION in ES query alert configurable #89561

Closed
ymao1 opened this issue Jan 28, 2021 · 1 comment · Fixed by #90089
Closed

[Alerting] Make DEFAULT_MAX_HITS_PER_EXECUTION in ES query alert configurable #89561

ymao1 opened this issue Jan 28, 2021 · 1 comment · Fixed by #90089
Assignees
@ymao1
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Jan 28, 2021

In the ES query alert type PR, the max number of hits allowed per execution is currently set to 1000 inside x-pack/plugins/stack_alerts/server/alert_types/es_query/alert_type.ts using DEFAULT_MAX_HITS_PER_EXECUTION. We should expose this configuration to the user as an alert param and allow them to set it, with a reasonable default and upper limit.
@ymao1 ymao1 added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jan 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 mentioned this issue Jan 29, 2021
Closed
@ymao1 ymao1 self-assigned this Feb 2, 2021
@ymao1 ymao1 mentioned this issue Feb 2, 2021
Merged
4 tasks
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymao1 ymao1

Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Alerting] Configurable number of hits for ES query alert ymao1/kibana
3 participants
@kobelb @ymao1 @elasticmachine