-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search Sessions] Cancel search session dialog is confusing for a completed, errored or expired session #89276
Comments
Pinging @elastic/kibana-app-services (Team:AppServices) |
@Dosant , yes, I agree. 'Delete' kind of implies that I can no longer do anything with it. But I'm able to reload it if I choose, correct? Maybe that's thinking too far into it, so I'm curious to see what others think. Maybe 'Archive'? |
@mdefazio, when you click "cancel" on that screen above search session disappears from the list, so you can't anymore use "reload". It seems like under the hood it is actually deleted (I am not sure). Not sure if this is intentional or a bug. |
@Dosant this needs to be addressed by one of @lukasolson PRs. |
@lizozom, thanks, that explains then. |
@Dosant not at the first MVP phase. |
@gchaps maybe you can review the text and buttons on this dialog? |
Discussed with @gchaps and here is copy for the delete modal: |
Part of #61738
Follow up on #61741
Noticed this small thing that confused me. I guess “cancel” for the completed session doesn’t make sense and should be “remove” or “delete” instead?
I think the same applies for the session in the "error" or "expired" state
@mdefazio, @lizozom, @tsullivan, wdyt?
The text was updated successfully, but these errors were encountered: