Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify parts of visualization state which should be stored in the URL. #8888

Closed
cjcenizal opened this issue Oct 29, 2016 · 1 comment
Closed
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Oct 29, 2016

Changes

We've succeeded in shortening our URLs by adding the ability to hash the states stored in it. Eventually we will remove even these from the URL. Let's identify parts of the visualization state which are appropriate for putting back into the URL by asking:

  1. Are any parts of the vis state which are very useful when surfaced as query params in the URL? For example, refreshInterval and timePeriod, which could be useful when programmatically building URLs.
  2. Are these parts of the vis state safe to put in the URL, i.e. is there any possibility they will grow so long as to trigger our IE URL length bug?
@tbragin tbragin added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Nov 2, 2016
@cjcenizal cjcenizal added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Nov 3, 2016
@snide snide removed the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Aug 14, 2018
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@timroes
Copy link
Contributor

timroes commented Oct 27, 2018

I would close this issue for now, since it seems kind of stalled, and there is no active consideration anymore going on, if we should remove parts of the visualize URL. Nevertheless when starting to build the new editor, we def want to give more thoughts into what needs to be part of the URL and what not.

@timroes timroes closed this as completed Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants