Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Research] UIState Per-panel Removal #88712

Closed
clintandrewhall opened this issue Jan 19, 2021 · 2 comments
Closed

[Research] UIState Per-panel Removal #88712

clintandrewhall opened this issue Jan 19, 2021 · 2 comments
Assignees
Labels
Breaking Change Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort R&D Research and development ticket (not meant to produce code, but to make a decision) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@clintandrewhall
Copy link
Contributor

clintandrewhall commented Jan 19, 2021

Summary of Exploration or Proposed Change

the uiState key is currently used to store inconsequential dashboard panel specific information. This includes whether or not to show the legend, and the color scheme.

As part of the Inline Editing project, it was decided that we would remove the existing UiState key in order to simplify where state is stored for embeddables, and minify the number of variables associated with panel editing in a dashboard.

Findings

Removing the UiState from the dashboard panels would be a fairly straightforward change. Many of the use cases that this covers, can be covered better with By Value panels.

Why is this a breaking change
If a cluster has multiple color customizations for the same by reference chart on different dashboards, those color customizations will be lost on upgrade. Migrating to keep these changes will not be possible without unlinking the panels from the library, which would not be an ideal solution.

  • Proposed Priority: Medium
  • Level of Effort: Medium
  • Dependencies:
    • Dependencies on Kibana App to ensure that they are able to cover all the existing use cases.
  • Proposed development: 7.14
@clintandrewhall clintandrewhall added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas R&D Research and development ticket (not meant to produce code, but to make a decision) Breaking Change 8.0.0 labels Jan 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@wylieconlon wylieconlon removed the 8.0.0 label Jan 20, 2021
@ThomThomson ThomThomson changed the title [8.0 Research] UIState Per-panel Removal [Research] UIState Per-panel Removal Jan 26, 2023
@ThomThomson ThomThomson added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort labels Jan 26, 2023
@ThomThomson
Copy link
Contributor

Closing this as UIState is currently removed from the Dashboard code and has been for some time. It only exists in the explicitInput of certain embeddable types - and those embeddable types are in change of their own state.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort R&D Research and development ticket (not meant to produce code, but to make a decision) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants