Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution][Detections] Provide finer grained feature controls between editing rules and modifying alerts #86235

Open
Tracked by #165878
spong opened this issue Dec 17, 2020 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Detection Alerts/Rules RBAC Security Solution RBAC for rules and alerts Feature:Detection Alerts Security Solution Detection Alerts Feature Feature:Detection Rules Security Solution rules and Detection Engine Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@spong
Copy link
Member

spong commented Dec 17, 2020

Currently it isn't possible to set up a Detections user such that they can update Alerts yet cannot modify Rules. The update alert status actions require canUserCRUD && hasIndexWrite permissions. Where canUserCrud is set to true when granting All to the Security app for the space, and hasIndexWrite being satisfied via the ES Index Privileges).

canUserCRUD is extracted from the Kibana application capabilities (uiCapabilities.siem.crud). Note the kibana application in code still remains siem, but is mapped to the Security application within the UI (as of 7.9.x+).

Note: it is possible to set the Saved Objects Management privilege to NONE to prevent rule creation (resulting in an error creating the exception-list-agnostic, however it is still possible to edit rules.

As a near-term fix, we could relax the canUserCrud check on the alert actions above and just rely on the signals index permissions, so you could then set the Security app permissions to READ and achieve permissions for editing alerts, but not rules, although this ends up being a little confusing since the Security app would be configured as read but allows edits. What we really need here are the finer grained kibana app privileges, and have an Update Alerts sub-item leveraging Kibana Feature Controls.

cc @MikePaquette @dhurley14

@spong spong added enhancement New value added to drive a business result Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Detection Alerts Security Solution Detection Alerts Feature v7.11.0 labels Dec 17, 2020
@dhurley14
Copy link
Contributor

dhurley14 commented Dec 18, 2020

I started working on this locally and made the change on the frontend to reduce the canUserCrud privileges on the alerts action bar but got a 403 error back when I closed an alert with a t1_analyst1 role. As of this change the introduction of the refresh parameter on the updateByQuery call requires one of the following privileges [maintenance,manage,all]

My understanding of this addition was the alerts count in the detections table was not accurate when we bulk closed alerts. The solution is we either remove this refresh parameter and find another fix for that bug or we have to update the privilege requirements for our base-level role of t1_analyst to include one of [maintenance,manage,all].

cc: @MikePaquette @spong

@spong
Copy link
Member Author

spong commented Jan 7, 2021

Thanks for the details @dhurley14! As discussed, let's move forward with the slight front-end changes to support this and understanding that the t1_analyst role will require the maintenance permissions for the .siem-signals* index as well in order to update an alert's state.

cc @jmikell821 @Donnater -- this change will require an update to the Detections pre-requisites docs here, as we'll need to call out the need for the maintenance permissions for .siem-signals* index. Honestly though, thoughts on re-organizing this page or having an additional page for detailing specific user roles and the required permissions? This would be really helpful for users to easily see what permissions they need to create common roles that would be used in SOCs like the t1_analyst role above. Thoughts?

@LeeDr
Copy link

LeeDr commented Jan 7, 2021

FYI, this issue has an enhancement label and a 7.11.0 label. Since we're past FF for 7.11.0 this should move out to 7.12.0.

@spong
Copy link
Member Author

spong commented Jan 7, 2021

Correct, thanks @LeeDr! We've got a minor fix going into 7.11 to address this for the near-term, but will keep this open as an enhancement for 7.12+. Removing version label for now until this is prioritized as part of a future effort.

@spong spong removed the v7.11.0 label Jan 7, 2021
@peluja1012 peluja1012 added Feature:Detection Alerts/Rules RBAC Security Solution RBAC for rules and alerts Team:Detection Alerts Security Detection Alerts Area Team labels Sep 15, 2021
@peluja1012 peluja1012 added Team:Security Solution Platform Security Solution Platform Team and removed Team:Detection Alerts Security Detection Alerts Area Team labels Aug 4, 2022
@Hashtpari
Copy link

@peluja1012 can you please confirm if this ticket can be closed or is it still outstanding as some parts of it have been merged? Thank you

@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Security Solution Platform Security Solution Platform Team labels May 14, 2023
@yctercero
Copy link
Contributor

This is still not implemented as a feature - leaving open for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Detection Alerts/Rules RBAC Security Solution RBAC for rules and alerts Feature:Detection Alerts Security Solution Detection Alerts Feature Feature:Detection Rules Security Solution rules and Detection Engine Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

6 participants