-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search Session] Use new URL Service for session restoration #85126
Comments
Pinging @elastic/kibana-app-services (Team:AppServices) |
The new URL service issue, rfc that will become a replacement of URL generators will allow passing the whole I think the plan with this is:
This will untie search-sessions from state in the URL as canvas/lens-editor will be able to create |
Can we write a migration to move existing saved search sessions to move to locators? |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Part of #61738
Original issue name: Restore sessions in apps that don't have the state stored in the URL (Lens, Canvas)
Original description
Problem:
We planned to rely on the URL to restore a background search session:
The problem is that not every app has all of its state stored in the URL, so not every app can support restoring all the states from the URL.
For example,
A possible alternative to generating a restoration URL is to navigate with the state in history.
Dashboard, Visualize and Lens already use this approach to "Save and return" flow when going back to dashboard from an editor: https://github.com/elastic/kibana/blob/master/src/plugins/embeddable/public/lib/state_transfer/embeddable_state_transfer.ts#L137
For session restoration, we use URL generators that will be removed in favor of the new URL service issue, rfc.
New URL service will allow transferring of a state using location state which will unblock apps that can't restore state from the URL from using search sessions (Lens, Canvas, some dashboard edge cases).
locators
This blocks #84908 unless we want to make first version where "send to background" is not available for viz with non-saved changes (also in this case saved session will break if lens viz changed after background search is saved)
cc @flash1293 @ThomThomson @lizozom @lukasolson @ppisljar
The text was updated successfully, but these errors were encountered: