Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Confusion matrix data grid issue #84427

Closed
darnautov opened this issue Nov 26, 2020 · 3 comments
Closed

[ML] Confusion matrix data grid issue #84427

darnautov opened this issue Nov 26, 2020 · 3 comments
Assignees
@alvarezmelissa87
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml

Comments

@darnautov
Copy link
Contributor

Kibana version:
master

Describe the bug:
Changing the configuration of the confusion matrix data grid causing loads of errors in the console and performs layout updates fairly slow

Screenshots (if relevant):
Nov-26-2020 16-48-57

Errors in browser console (if relevant):

Click to expand 
react-dom.development.js:385 Uncaught RangeError: Maximum call stack size exceeded.
  at Object.invokeGuardedCallbackDev (react-dom.development.js:385)
  at invokeGuardedCallback (react-dom.development.js:440)
  at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:454)
  at executeDispatch (react-dom.development.js:584)
  at executeDispatchesInOrder (react-dom.development.js:609)
  at executeDispatchesAndRelease (react-dom.development.js:713)
  at executeDispatchesAndReleaseTopLevel (react-dom.development.js:722)
  at forEachAccumulated (react-dom.development.js:694)
  at runEventsInBatch (react-dom.development.js:739)
  at runExtractedPluginEventsInBatch (react-dom.development.js:880)
invokeGuardedCallbackDev @ react-dom.development.js:385
invokeGuardedCallback @ react-dom.development.js:440
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:454
executeDispatch @ react-dom.development.js:584
executeDispatchesInOrder @ react-dom.development.js:609
executeDispatchesAndRelease @ react-dom.development.js:713
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:722
forEachAccumulated @ react-dom.development.js:694
runEventsInBatch @ react-dom.development.js:739
runExtractedPluginEventsInBatch @ react-dom.development.js:880
handleTopLevel @ react-dom.development.js:5803
batchedEventUpdates$1 @ react-dom.development.js:24401
batchedEventUpdates @ react-dom.development.js:1415
dispatchEventForPluginEventSystem @ react-dom.development.js:5894
attemptToDispatchEvent @ react-dom.development.js:6010
dispatchEvent @ react-dom.development.js:5914
unstable_runWithPriority @ scheduler.development.js:697
runWithPriority$2 @ react-dom.development.js:12149
discreteUpdates$1 @ react-dom.development.js:24417
discreteUpdates @ react-dom.development.js:1438
dispatchDiscreteEvent @ react-dom.development.js:5881
focusOn @ setFocus.js:4
(anonymous) @ setFocus.js:31
activateTrap @ Trap.js:109
onTrap @ Trap.js:148
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
(anonymous) @ data_grid_header_cell.js:143
commitHookEffectList @ react-dom.development.js:22030
commitPassiveHookEffects @ react-dom.development.js:22064
callCallback @ react-dom.development.js:336
invokeGuardedCallbackDev @ react-dom.development.js:385
invokeGuardedCallback @ react-dom.development.js:440
flushPassiveEffectsImpl @ react-dom.development.js:25392
unstable_runWithPriority @ scheduler.development.js:697
runWithPriority$2 @ react-dom.development.js:12149
flushPassiveEffects @ react-dom.development.js:25361
(anonymous) @ react-dom.development.js:25240
workLoop @ scheduler.development.js:641
flushWork @ scheduler.development.js:596
performWorkUntilDeadline @ scheduler.development.js:203
Show 49 more frames
react-dom.development.js:394 Uncaught Error: An error was thrown inside one of your components, but React doesn't know what it was. This is likely due to browser flakiness. React does its best to preserve the "Pause on exceptions" behavior of the DevTools, which requires some DEV-mode only tricks. It's possible that these don't work in your browser. Try triggering the error in production mode, or switching to a modern browser. If you suspect that this is actually an issue with React, please file an issue.
  at Object.invokeGuardedCallbackDev (react-dom.development.js:394)
  at invokeGuardedCallback (react-dom.development.js:440)
  at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:454)
  at executeDispatch (react-dom.development.js:584)
  at executeDispatchesInOrder (react-dom.development.js:609)
  at executeDispatchesAndRelease (react-dom.development.js:713)
  at executeDispatchesAndReleaseTopLevel (react-dom.development.js:722)
  at forEachAccumulated (react-dom.development.js:694)
  at runEventsInBatch (react-dom.development.js:739)
  at runExtractedPluginEventsInBatch (react-dom.development.js:880)
invokeGuardedCallbackDev @ react-dom.development.js:394
invokeGuardedCallback @ react-dom.development.js:440
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:454
executeDispatch @ react-dom.development.js:584
executeDispatchesInOrder @ react-dom.development.js:609
executeDispatchesAndRelease @ react-dom.development.js:713
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:722
forEachAccumulated @ react-dom.development.js:694
runEventsInBatch @ react-dom.development.js:739
runExtractedPluginEventsInBatch @ react-dom.development.js:880
handleTopLevel @ react-dom.development.js:5803
batchedEventUpdates$1 @ react-dom.development.js:24401
batchedEventUpdates @ react-dom.development.js:1415
dispatchEventForPluginEventSystem @ react-dom.development.js:5894
attemptToDispatchEvent @ react-dom.development.js:6010
dispatchEvent @ react-dom.development.js:5914
unstable_runWithPriority @ scheduler.development.js:697
runWithPriority$2 @ react-dom.development.js:12149
discreteUpdates$1 @ react-dom.development.js:24417
discreteUpdates @ react-dom.development.js:1438
dispatchDiscreteEvent @ react-dom.development.js:5881
focusOn @ setFocus.js:4
(anonymous) @ setFocus.js:31
activateTrap @ Trap.js:109
onTrap @ Trap.js:148
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
onFocusIn @ data_grid_header_cell.js:173
(anonymous) @ data_grid_header_cell.js:143
commitHookEffectList @ react-dom.development.js:22030
commitPassiveHookEffects @ react-dom.development.js:22064
callCallback @ react-dom.development.js:336
invokeGuardedCallbackDev @ react-dom.development.js:385
invokeGuardedCallback @ react-dom.development.js:440
flushPassiveEffectsImpl @ react-dom.development.js:25392
unstable_runWithPriority @ scheduler.development.js:697
runWithPriority$2 @ react-dom.development.js:12149
flushPassiveEffects @ react-dom.development.js:25361
(anonymous) @ react-dom.development.js:25240
workLoop @ scheduler.development.js:641
flushWork @ scheduler.development.js:596
performWorkUntilDeadline @ scheduler.development.js:203
Show 49 more frames
setFocus.js:4 Uncaught RangeError: Maximum call stack size exceeded.
  at focusOn (setFocus.js:4)
  at setFocus.js:31
  at activateTrap (Trap.js:109)
  at HTMLDocument.onTrap (Trap.js:148)
  at HTMLDivElement.onFocusIn (data_grid_header_cell.js:173)
  at HTMLDivElement.onFocusIn (data_grid_header_cell.js:173)
  at HTMLDivElement.onFocusIn (data_grid_header_cell.js:173)
  at HTMLDivElement.onFocusIn (data_grid_header_cell.js:173)
  at HTMLDivElement.onFocusIn (data_grid_header_cell.js:173)
  at HTMLDivElement.onFocusIn (data_grid_header_cell.js:173)
@darnautov darnautov added bug Fixes for quality problems that affect the customer experience :ml Feature:Data Frame Analytics ML data frame analytics features labels Nov 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87
Copy link
Contributor

alvarezmelissa87 commented Dec 15, 2020 •
edited
Loading

Had a chat with @chandlerprall - looks like it's most likely a known issue (with DataGrid - elastic/eui#4384) around this - if a header is focused and then you move that column to a new position. It will likely need to be fixed on the EUI side.

Checked that moving focus to a non-header cell before reenabling the column doesn't error - looks like it is the EUI issue.

@alvarezmelissa87
Copy link
Contributor

Gave this a test with latest master and can no longer reproduce. Closing this as it is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@darnautov @alvarezmelissa87 @peteharverson @elasticmachine