Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Limit operation choices based on chart type #84111

Closed
Tracked by #184459
flash1293 opened this issue Nov 23, 2020 · 3 comments
Closed
Tracked by #184459

[Lens] Limit operation choices based on chart type #84111

flash1293 opened this issue Nov 23, 2020 · 3 comments
Labels
discuss Feature:Lens 🧊 iceboxed Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Not all operations make sense for all kinds of charts.

E.g operations which don't sum up to a meaningful total (average, median, min/max) are rarely helpful on a pie chart. This issue is meant to discuss whether we want to limit the choice of operations in some way based on the currently active chart beyond matching data types and metrics/buckets (which is already done).

I'm personally not in favor of completely disallowing these operations for two reasons:

  • We allow them today so it would be a breaking change
  • If the data is structured a certain way only the user can know, it's possible for these operations to be meaningful even if that's not true in the general case

My suggestion: Allow and show operations even if we don't think they are a good match for the current chart type, but highlight them and add an exemplary tooltip to make it clear that's probably not what should be used.

@flash1293 flash1293 added discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

wylieconlon commented Nov 23, 2020

I've previously considered tagging all of these functions as "summable" numbers, because they can easily and correctly be stacked or converted to a percentage. So specifically we know that Count/Sum/Cardinality can be stacked, while we can't guarantee that Avg/Min/Max/Median/Percentile can stack. I'm stuck on the wording, but do you think this is the right way of categorizing it?

I agree that we should find a way to discourage non-standard charts, while still allowing users who know what they're doing.

@markov00
Copy link
Member

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Lens general improvements ice box #184459

@markov00 markov00 closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Lens 🧊 iceboxed Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants