Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expressions] Convert interpreter_functional test suite to use new unified expectSnapshot implementation. #83955

Closed
lukeelmers opened this issue Nov 20, 2020 · 2 comments
Closed

[expressions] Convert interpreter_functional test suite to use new unified expectSnapshot implementation. #83955

lukeelmers opened this issue Nov 20, 2020 · 2 comments
Labels
chore Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@lukeelmers
Copy link
Member

Currently the test/interpreter_functional suite has its own implementation of Jest-like snapshots for testing. Since #82932 has been merged there's now a unified snapshot implementation that can be used across functional test suites... we should look into replacing the existing interpreter test snapshots with the new shared ones.
@lukeelmers lukeelmers added chore Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) loe:small Small Level of Effort Team:AppServices labels Nov 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@lukeelmers lukeelmers mentioned this issue Nov 20, 2020
Closed
4 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Apr 20, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 10, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Jan 5, 2022
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukeelmers @ppisljar @elasticmachine @petrklapka