Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Enable missing values option for percentage stack area charts as well #82760

Closed
Tracked by #184459
dej611 opened this issue Nov 5, 2020 · 4 comments
Closed
Tracked by #184459
Labels
enhancement New value added to drive a business result Feature:Lens 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dej611
Copy link
Contributor

dej611 commented Nov 5, 2020

In Lens the Percentage Area charts do not support the "Missing values" feature, probably due to initial lack of support in the elastic-charts library.

I've asked @nickofthyme and he confirmed that the library now supports the feature (see link ), therefore it is technically possible to enable it.

Before the actual implementation may be worth to discuss about it (cc @markov00 @flash1293 )

@dej611 dej611 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

wylieconlon commented Nov 5, 2020

I am definitely in favor of supporting this feature for area and stacked area charts. I wonder if we should actually set a default fitting function of Zero for these charts because the way that stacked area charts render is problematic without this. The data in the screenshots is random, so it's not a direct comparison of the data, but just the aesthetic:

Current default with holes:

Screen Shot 2020-11-05 at 2 28 45 PM

The new default I'm proposing for Area charts, Zero fitting function:

Screen Shot 2020-11-05 at 2 28 56 PM

@dej611
Copy link
Contributor Author

dej611 commented Jun 23, 2021

The Zero setting is current default for Area percentage charts.
Not sure whether it makes sense to add more options, but in case we want to add it, probably we should reset to default fit when transitioning to Area Percentage mode. WDYT?

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Sep 6, 2023
@timductive timductive added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 20, 2024
@markov00
Copy link
Member

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Lens general improvements ice box #184459

@markov00 markov00 closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants