Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Replace custom kuery bar with shared SearchBar / TopNavMenu #82751

Closed
smith opened this issue Nov 5, 2020 · 8 comments
Closed

[APM] Replace custom kuery bar with shared SearchBar / TopNavMenu #82751

smith opened this issue Nov 5, 2020 · 8 comments
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture

Comments

@smith
Copy link
Contributor

smith commented Nov 5, 2020

The navigation plugin exposes a TopNavMenu component that includes the query bar and date picker.

We should use this instead of our own components in APM and Observability plugins.

image
The Search Bar in Discover

@smith smith added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Nov 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith added [zube]: Inbox technical debt Improvement of the software architecture and operational architecture and removed [zube]: Inbox labels Nov 9, 2020
@sorenlouv sorenlouv changed the title [APM] Investigate use of shared SearchBar component [APM] Replace custom kuery bar with shared SearchBar / TopNavMenu Nov 30, 2020
@sorenlouv sorenlouv removed the v7.13.0 label Feb 23, 2021
@alex-fedotyev
Copy link

This needs more alignment across observability - when logs and metrics are doing this? Or is it already in place?

@smith
Copy link
Contributor Author

smith commented Mar 24, 2021

@alex-fedotyev each solution in Observability is using its own search bar implementation at this time, so none of us are using the search bar provided in most other apps in Kibana.

Since the shared component can also do filtering, this is also related to the exploration of filtering that @formgeist is doing on elastic/observability-design#24.

@honzakral
Copy link
Contributor

Any idea on the timeline here? I see that 7.13 target was dropped so came to ask.

I have a use case which is quite important for me - to be able to filter on "User Experience" app by customer, user. anonymous, ... but there is no support in the UI. Right now my hacky solution would be to have different environments for these settings but it messes up other parts of the APM and shouldn't really be needed.

Thanks!

@formgeist
Copy link
Contributor

@honzakral Hope you're doing well! You're right that we have been pushing this particular issue back in order to investigate switching to the global header search bar and date picker instead of relying on individual implementations in each of the Observability apps. This issue is specifically for switching it in the APM app, but I've created a new issue to add a search bar to the UX app.

@honzakral
Copy link
Contributor

@formgeist thank you, much appreciated! I will watch the issue you created. I wasn't sure where the UX apps falls so I followed the data to APM and found this.

@smith
Copy link
Contributor Author

smith commented Oct 11, 2022

This issue should be updated to use the Unified Search components instead of the older ones referenced in the description.

@smith
Copy link
Contributor Author

smith commented Mar 6, 2024

We've got unified search so this is no longer needed.

@smith smith closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

8 participants