Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal links registered with core.chrome.setHelpExtension cause full page reload #82158

Closed
smith opened this issue Oct 30, 2020 · 3 comments · Fixed by #82300
Closed

Internal links registered with core.chrome.setHelpExtension cause full page reload #82158

smith opened this issue Oct 30, 2020 · 3 comments · Fixed by #82300
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@smith
Copy link
Contributor

smith commented Oct 30, 2020

When adding a link to the upper-right help menu using core.chrome.setHelpExtension, links internal to Kibana cause a full page reload.

APM example:

{
linkType: 'custom',
href: url.format({
pathname: http.basePath.prepend('/app/kibana'),
hash: '/management/stack/upgrade_assistant',
}),
content: i18n.translate('xpack.apm.helpMenu.upgradeAssistantLink', {
defaultMessage: 'Upgrade assistant',
}),
},

The expected behavior is a navigation without the full page reload.

@smith smith added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet added the bug Fixes for quality problems that affect the customer experience label Oct 30, 2020
@pgayvallet
Copy link
Contributor

We would just need to use application.navigateToUrl in a onClick handler in addition to the current href

@pgayvallet
Copy link
Contributor

Changing from bug to enhancement, as I missed that it was already possible to work around that by manually providing an onClick handler

export type ChromeHelpExtensionMenuCustomLink = EuiButtonEmptyProps & {

@pgayvallet pgayvallet added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants