Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make encryptedSavedObjects plugin dependency optional and stop relying on usingEphemeralEncryptionKey #81618

Closed
azasypkin opened this issue Oct 26, 2020 · 5 comments · Fixed by #88884
Assignees
Labels

Comments

@azasypkin
Copy link
Member

azasypkin commented Oct 26, 2020

As we agreed in #79943 (comment) Monitoring plugin should make encryptedSavedObjects plugin dependency optional (if not done yet) and stop relying on usingEphemeralEncryptionKey setup contract property.

If encryptedSavedObjects dependency is available that would mean that the proper encryption key is set, otherwise dependency won't be available.

NOTE: we can update encryptedSavedObjects plugin behavior only once all consumers stop using usingEphemeralEncryptionKey, we are targeting 7.12 and hence marking all related issues as blocking for that release.

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@nreese
Copy link
Contributor

nreese commented Oct 27, 2020

Closing, duplicate of #81619

@nreese nreese closed this as completed Oct 27, 2020
@azasypkin azasypkin reopened this Oct 28, 2020
@azasypkin azasypkin added v7.12.0 and removed v7.11.0 labels Oct 29, 2020
@azasypkin
Copy link
Member Author

Hey @elastic/stack-monitoring ,

Can you please confirm that you're still targeting 7.12 for this work? Once you merge your part we'll remove usingEphemeralEncryptionKey from the EncryptedSavedObjects plugin contract in #81511.

Thanks!

@chrisronline
Copy link
Contributor

@azasypkin Yes, we can do this for 7.12

@chrisronline
Copy link
Contributor

@azasypkin This is up now: #88884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants