[Security Solution] IBM and Jira connectors cannot be used after an upgrade

[MadameSheema]

Kibana & Elasticsearch version:

• 7.10 BC3

Describe the bug:

• IBM and Jira connectors cannot be used after an upgrade

Initial status:

• To have a elasticsearch and kibana instances in 7.9.2v
• To have Jira, IBM and SN connectors configured
• To have a case pushed to all the third parties, being SN the last one.

Steps to reproduce:

1. Upgrade the instances to 7.10
2. Open the created case
3. Select a Jira connector

Current behavior:

• The following error is displayed

• The same error is displayed when you try to change the connector to IBM resilient

Expected behavior:

• No error is displayed
• The connector can be used

[pmuellr]

Looks like the problem is that the migrations lump together cases and emails to run all the migrations, so cases will get the same hasAuth migration that is supposed to be just for emails:

kibana/x-pack/plugins/actions/server/saved_objects/migrations.ts

Lines 22 to 26 in 7e34bf2

	const migrationActions = encryptedSavedObjects.createMigration<RawAction, RawAction>(
	(doc): doc is SavedObjectUnsanitizedDoc<RawAction> =>
	!!doc.attributes.config?.casesConfiguration || doc.attributes.actionTypeId === '.email',
	pipeMigrations(renameCasesConfigurationObject, addHasAuthConfigurationObject)
	);

I think we should add a filter at the top of the email migrator, like:

if (!doc.attributes.actionTypeId !== '.email') {
    return doc;
  }

Cases has a similar kind of check, which is probably good enough, checking an expected cases attribute - is more of a "duck typing" kind of test rather than explicit actionTypeId test, which is probably better since otherwise we'll have to enumerate all the case types and then we'll forget one someday.

[elasticmachine]

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

[pmuellr]

Next 7.10.0 build candidate looks to be 2020-10-28.

[MadameSheema]

Reopening the issue to remember to validate it during next BC.

[ghost]

Bug Conversion:

Created 03 new Test-Cases for this Ticket

• https://elastic.testrail.io/index.php?/cases/view/35125
• https://elastic.testrail.io/index.php?/cases/view/35126
• https://elastic.testrail.io/index.php?/cases/view/35127

Thanks