Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect saved object doesn't respect base path #80827

Closed
Dosant opened this issue Oct 16, 2020 · 3 comments · Fixed by #80950
Closed

Inspect saved object doesn't respect base path #80827

Dosant opened this issue Oct 16, 2020 · 3 comments · Fixed by #80950
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Oct 16, 2020

Kibana version: 7.10, master (works in 7.9.2)
Original install method (e.g. download page, yum, from source, etc.): Cloud + local master

Describe the bug:

Inspect option in SO context menu doesn't respect Kibana's base path when navigating.
I checked at least visualize SO and dashboard SO, but I think it is a global issue.

Steps to reproduce:

  1. Create a space and create an SO
  2. go to managements -> Saved Objects -> pick a saved object -> Inspect
  3. Navigate outside of space

Expected behavior:

Base path is taken into account

Screenshots (if relevant):

I am in non-default space:

Screenshot 2020-10-16 at 15 38 49

Navigating to SO get redirect to default space and SO doesn't exist in default space:

Screenshot 2020-10-16 at 15 39 01

Any additional context:

  • Checked that it works in 7.9.2
  • In case of local development with dynamic base path you get 404 on inspect
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc regression Feature:Saved Objects v7.10.0 labels Oct 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor

Got a different, but still broken, behavior on my local instance. When clicking inspect, I get that:

Screenshot 2020-10-16 at 17 34 36

Root caused is still the lack of basePath in the url/action though.

@pgayvallet
Copy link
Contributor

Seems like that was actually introduced by #66781 : https://github.com/elastic/kibana/pull/66781/files#diff-9c8e3a0080e7f9c4933b22ef59b7b2285b20791870b6ba1548229843538833f6 is not appending the basePath.

The bug is not present on 7.9 because #78565 that was fixing navigating to a path without specifying the basePath only got merged in 7.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants