Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Geo containment alert V1 completion tasks #80749

Closed
15 of 20 tasks
kindsun opened this issue Oct 15, 2020 · 6 comments
Closed
15 of 20 tasks

[Maps] Geo containment alert V1 completion tasks #80749

kindsun opened this issue Oct 15, 2020 · 6 comments
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Alerting Meta

Comments

@kindsun
Copy link
Contributor

kindsun commented Oct 15, 2020

Following up on #76285, there are several issues we'll want to address that came of review and separate discussion. Most of these should be targeted for feature completeness of Geo Threshold Alerts V1 (i.e.- when the experimental flag comes off) however some may bleed over into V2.

The first 4 under Dev are roughly in the order they'll be tackled, the rest are open to shuffling:

Dev

Phase 2 Catch-all (can be ported to new issue)

  • Allow max vars to be configurable
  • Communicate to user if any of the preset maxes have been hit Introduce geo-threshold alerts #76285 (review))
  • API options?
  • Auto-generated solutions layers for easier Alerts review and general visibility

Old tasks no longer relevant

- [ ] Consider looking at multiple crossings within interval window?
- [ ] Make crossing time a human readable timestamp instead of unix timestamp

Design

cc @kmartastic @thomasneirynck @miukimiu @YulNaumenko

@kindsun kindsun added Meta [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Alerting labels Oct 15, 2020
@kindsun kindsun self-assigned this Oct 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kmartastic
Copy link
Contributor

  • Add geo_shape tracking

Unless this is a simple task (like 10 lines of code or flipping a switch), I don't think we need to do this work for v.1 or v.2.

The list looks good @aaronjcaldwell.

@kindsun
Copy link
Contributor Author

kindsun commented Oct 16, 2020

  • Add geo_shape tracking

Unless this is a simple task (like 10 lines of code or flipping a switch), I don't think we need to do this work for v.1 or v.2.

The list looks good @aaronjcaldwell.

👍 Thanks @kmartastic! The query is easy (literally almost the same) but it requires a little more thought around UX and indexing content, like do we still provide lines connecting previous & current locations and if so do we connect centroids, etc. I think it's safe to drop it from this list and circle back on it as needed in a future version.

@mikecote
Copy link
Contributor

mikecote commented Nov 6, 2020

Add readme for alert built-in

I recently merged a PR (#81526) that allows the alert flyout to link to the documentation. Once the docs are in, you can add the url here in the alert type model.

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Nov 9, 2020

Before going GA with this, imho we should remove time-field from selection. details here: #83013

Selecting a time-field that is different from the time-field of the index-pattern creates unnecessary avenue for bugs and misconfigurations, and will hurt us long term when building other features on top of this (e.g. layer-templates etc..)

@kindsun kindsun changed the title [Maps] Geo threshold alert V1 completion tasks [Maps] Geo containment alert V1 completion tasks Jan 26, 2021
@thomasneirynck
Copy link
Contributor

closed, v1 completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Alerting Meta
Projects
None yet
Development

No branches or pull requests

5 participants