Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Use the ML plugin's url generator for cross-app links #79426

Closed
weltenwort opened this issue Oct 5, 2020 · 1 comment
Closed

[Logs UI] Use the ML plugin's url generator for cross-app links #79426

weltenwort opened this issue Oct 5, 2020 · 1 comment
Assignees
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Milestone

Comments

@weltenwort
Copy link
Member

weltenwort commented Oct 5, 2020

Summary

Currently the deep link URLs from the Logs UI to the various views in the ML UI are hard-coded. Since #78209 the ml plugin exports a hook useMlHref which can be used to abstract away the URL generation. If we used the hook we would deduplicate the URL generation logic and make it more robust to future changes.

Acceptance criteria

  • URLs from the Logs UI to the ML UI are not hard-coded, but generated using the helpers provided by the ml plugin.

Related links

@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants