Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization infrastructure cleanup #78578

Closed
4 tasks done
timroes opened this issue Sep 28, 2020 · 1 comment · Fixed by #88317
Closed
4 tasks done

Visualization infrastructure cleanup #78578

timroes opened this issue Sep 28, 2020 · 1 comment · Fixed by #88317
Assignees
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Meta refactoring Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@timroes
Copy link
Contributor

timroes commented Sep 28, 2020

This issue outlines a couple of cleanups we still wanted/should do within the visualization infrastructure:

  • [ ] Potentially combine the visualize and visualizations plugin into one. The split was mainly done because of codeownership of those plugins. Now since the same team owns them there is no really a use-case to keep those (anyway arbitrary drawn boundary) still alive and we should bring them back into one plugin. There could also be a use-case in case of dependencies to not keep the visualize application in the same, so we still need to make a final decicion about this. @sulemanof and @timroes discussed this, and we agreed to keep them separate, given the dependencies.
  • After we've created individual renderers for all visualizations (see Renderers for all visualizations #46801) we should cleanup the whole (then unused) Visualization class and a couple of dependant classes (like Vis).
  • Also after that, we should remove the build_pipelines.ts utility.
  • TypeScript cleanups:
    • Remove any index signature from VisType (src/plugins/visualizations/public/vis_types/types_service.ts)

cc @stratoula

@timroes timroes added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Meta refactoring Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the technical debt Improvement of the software architecture and operational architecture label Oct 19, 2020
@sulemanof sulemanof self-assigned this Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Meta refactoring Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants