[APM] Service Map: Not Defined option doesn't work properly

[sorenlouv]

There seems to be a problem displaying the service map for services without environment.

When "All" environments is selected the services and the outgoing calls are correctly displayed:

However, if "Not defined" is selected none of the outgoing requests are displayed:

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[dgieselaar]

Does this service (elastic-co-rum-test) not have an environment?

[dgieselaar]

Possibly because ENVIRONMENT_NOT_DEFINED is not being handled in two places:
https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/server/lib/service_map/get_trace_sample_ids.ts#L50
https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/server/lib/service_map/get_service_map_from_trace_ids.ts#L38

[sorenlouv]

Does this service (elastic-co-rum-test) not have an environment?

If it did, it should show up in the environment selector (unless that's where the bug lies)

[sorenlouv]

Possibly because ENVIRONMENT_NOT_DEFINED is not being handled in two places:

Good catch. We should use this logic for filtering by environment:

kibana/x-pack/plugins/apm/server/lib/helpers/convert_ui_filters/get_environment_ui_filter_es.ts

Lines 11 to 19 in ebf877b

	export function getEnvironmentUiFilterES(environment?: string): ESFilter[] {
	if (!environment) {
	return [];
	}
	if (environment === ENVIRONMENT_NOT_DEFINED.value) {
	return [{ bool: { must_not: { exists: { field: SERVICE_ENVIRONMENT } } } }];
	}
	return [{ term: { [SERVICE_ENVIRONMENT]: environment } }];
	}