You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In retrospect, I picked a really bad name for the new alert client API we added in this PR: #68437 - getAlertStatus. Primarily because we will be promoting/enhancing an overall alert "status" in the fix for this issue: #51099 . There is also an alert state, which is a different thing, and as such ... it would be better to come up with a new name for this.
I don't have a lot of suggestions, other than since the data returned from the current getAlertStatus() is based off events that occurred during some time range (and some default time range based on the alert interval is used), and that time range always end with "now", it should factor some concept of "time" in it.
Perhaps something like getRecentAlertSummary()?
Note that the peer HTTP API should also be similarly renamed.
The text was updated successfully, but these errors were encountered:
As I'm working on the "general" alert status, I realized that "instance" should be part of the API name here, as it's specifically getting instance status.
It does a bit more though, like collecting all the errors over the time range, so somehow working "summary" in the name might work, or a name indicating that it's working off historic data vs the current state.
Something like getHistoricSummary() feels like it captures the intent, but also sounds kinda weird.
In retrospect, I picked a really bad name for the new alert client API we added in this PR: #68437 -
getAlertStatus
. Primarily because we will be promoting/enhancing an overall alert "status" in the fix for this issue: #51099 . There is also an alertstate
, which is a different thing, and as such ... it would be better to come up with a new name for this.I don't have a lot of suggestions, other than since the data returned from the current
getAlertStatus()
is based off events that occurred during some time range (and some default time range based on the alert interval is used), and that time range always end with "now", it should factor some concept of "time" in it.Perhaps something like
getRecentAlertSummary()
?Note that the peer HTTP API should also be similarly renamed.
The text was updated successfully, but these errors were encountered: