Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Regression bug with xpack.reporting.capture.browser.chromium.proxy.bypass #74568

Closed
tsullivan opened this issue Aug 6, 2020 · 2 comments · Fixed by #74693
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:Reporting:Framework Reporting issues pertaining to the overall framework needs-team Issues missing a team label

Comments

@tsullivan
Copy link
Member

Kibana version: 7.8.0

Describe the bug:
A bug introduced in regards to the following setting: xpack.reporting.capture.browser.chromium.proxy.bypass

FATAL Error: [config validation of [xpack.reporting].capture.browser.chromium.proxy.bypass.3]: value must be a valid hostname (see RFC 1123).

According to the documentation : https://www.elastic.co/guide/en/kibana/current/reporting-settings-kb.html , it is valid to contain wildcards and port numbers: *.elastic.co", ".elastic.co", ".elastic.co:5601.

Also port numbers in names in the array doesn't seem to be allowed , even though the documentation says it is valid.

Additional information:
The bypass setting can be upgraded by using an array of host names, instead of a wildcard. Example:

xpack.reporting.capture.browser.chromium.proxy.enabled : true
xpack.reporting.capture.browser.chromium.proxy.server: http://example.com:8080
xpack.reporting.capture.browser.chromium.proxy.bypass : [ "foo.example.com", "bar.example.com", "bats.example.com" ]

whereas in 7.7.x, this config could have been used:

xpack.reporting.capture.browser.chromium.proxy.enabled : true
xpack.reporting.capture.browser.chromium.proxy.server: http://example:8080
xpack.reporting.capture.browser.chromium.proxy.bypass : [ "*.example.com" ]
@tsullivan tsullivan added bug Fixes for quality problems that affect the customer experience Team:Reporting Services labels Aug 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan
Copy link
Member Author

It looks like the bug was added in this PR, on this line: https://github.com/elastic/kibana/pull/61696/files#diff-e4c9f182be24f47d092c8c3d21878cb5R100

@sophiec20 sophiec20 added Feature:Reporting:Framework Reporting issues pertaining to the overall framework and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Reporting:Framework Reporting issues pertaining to the overall framework needs-team Issues missing a team label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants