Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting team plugins to use synchronous setup and start functions #74395

Closed
mikecote opened this issue Aug 5, 2020 · 3 comments · Fixed by #89562
Closed

Alerting team plugins to use synchronous setup and start functions #74395

mikecote opened this issue Aug 5, 2020 · 3 comments · Fixed by #89562
Labels
Feature:Actions Feature:Alerting R&D Research and development ticket (not meant to produce code, but to make a decision) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Aug 5, 2020 •
edited
Loading

The platform team is working on making the plugin lifecycle not block Kibana on start up (https://github.com/elastic/kibana/blob/master/rfcs/text/0007_lifecycle_unblocked.md). This would force plugin developers to make setup and start synchronous functions before the last 7.x minor (7.14 so far).

We should go over the plugins we own and make the plugin functions synchronous.

There are also timeouts within the setup and start functions that is already implemented; <7.10 is 30s and 7.10+ is 10s.
@mikecote mikecote added Feature:Alerting Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr pmuellr added the loe:needs-research This issue requires some research before it can be worked on or estimated label Aug 6, 2020
@mikecote mikecote mentioned this issue Aug 13, 2020
Merged
@mikecote mikecote added R&D Research and development ticket (not meant to produce code, but to make a decision) and removed loe:needs-research This issue requires some research before it can be worked on or estimated labels Aug 26, 2020
@mikecote mikecote mentioned this issue Oct 27, 2020
Merged
@YulNaumenko
Copy link
Contributor

I think this is already done under this PR #89562

@mikecote mikecote mentioned this issue Feb 4, 2021
Merged
2 tasks
@mikecote
Copy link
Contributor Author

mikecote commented Feb 4, 2021

@YulNaumenko yup, I took a look and confirmed! ❤️ The issue will now auto-resolve and is "in-review" now.

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Actions Feature:Alerting R&D Research and development ticket (not meant to produce code, but to make a decision) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate most plugins to synchronous lifecycle pgayvallet/kibana
5 participants
@pmuellr @kobelb @mikecote @elasticmachine @YulNaumenko