Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Remove async from server plugin setup #74374

Closed
Tracked by #74378
poffdeluxe opened this issue Aug 5, 2020 · 2 comments
Closed
Tracked by #74378

[Canvas] Remove async from server plugin setup #74374

poffdeluxe opened this issue Aug 5, 2020 · 2 comments
Labels
Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0

Comments

@poffdeluxe
Copy link
Contributor

In 8.0, Kibana platform will not longer allow plugins to return a promise from the lifecycle methods.

We should remove the async/await usage from our server plugin setup (I believe we're using it for setting up usage collector)
@poffdeluxe poffdeluxe added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Aug 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@poffdeluxe poffdeluxe mentioned this issue Aug 5, 2020
Closed
2 tasks
@poffdeluxe
Copy link
Contributor Author

Fixed by #89562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@poffdeluxe @timroes @elasticmachine