Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Page CSS is a little wonky #7347

Closed
pickypg opened this issue Jun 1, 2016 · 1 comment
Closed

Status Page CSS is a little wonky #7347

pickypg opened this issue Jun 1, 2016 · 1 comment
Labels

Comments

@pickypg
Copy link
Member

pickypg commented Jun 1, 2016

Related to #7335

While adding the version field to the status page, I inevitably screwed up the layout of the plugin listing table. While fixing it, I noticed that the CSS for the page seems a little off.

For example, when I added the Bootstrap table class to the table, it made the text in the table positioned improperly, which makes it odd to use Bootstrap without Bootstrap. It also seems odd that the table uses col-xs-* while the top-level elements use col-md-* only.

It also seems like some of the CSS could be simplified by just taking advantage of Bootstrap CSS (e.g., .row on the tr could be used rather than .status_row with added properties).

Overall:

  • Should use the same col-*-size styling.
  • Should use provided CSS where possible without duping it. We can extend it with our own markers (e.g., table.plugin_status_breakdown > tr.row { ... }).
  • Should probably look at using .table for tables and also the .table-responsive wrapper.

For reference, here's the status page on master:

Status

Note:

@cjcenizal
Copy link
Contributor

Closing this in favor of #20001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants