Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel error reported in production due to Canvas presentation template size #72996

Closed
tylersmalley opened this issue Jul 23, 2020 · 8 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Operations Team label for Operations Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0

Comments

@tylersmalley
Copy link
Contributor

We either need to remove our use of babel/register, or come up with a different solution for the Canvas template, assuming it's required.

[BABEL] Note: The code generator has deoptimised the styling of /usr/share/kibana/x-pack/plugins/canvas/server/templates/pitch_presentation.js as it exceeds the max of 500KB.
@tylersmalley tylersmalley added Team:Operations Team label for Operations Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 labels Jul 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@clintandrewhall
Copy link
Contributor

@crob611 Can you weigh in on this, particularly with our plans to move templates to Saved Object?

@tylersmalley What would be the best option in the short term?

@jbudz
Copy link
Member

jbudz commented Jul 23, 2020

thoughts on silencing? minimal changeset for freeze, haven't tested tho

{
    "env": {
      "production" : {
        "compact": false
      }
    }
}

https://babeljs.io/docs/en/options for ref

@timductive timductive added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jul 30, 2020
@like-inspur
Copy link

I also met this error when kibana start although I have config "xpack.canvas.enabled: false" in kibana.yml

@spalger
Copy link
Contributor

spalger commented Oct 21, 2020

This is fixed in 7.10 by #79379. @like-inspur unfortunately we still load the code for the canvas plugin so that we can detect it's config schema, even though you disabled canvas we still were passing it through babel in production, but not anymore once 7.10 is released!

@spalger spalger closed this as completed Oct 21, 2020
@Asgoret
Copy link

Asgoret commented Oct 28, 2020

@spalger Hi! when it will happen? In docker hub there is only 7.9.3 and I go this issue

@kenseii
Copy link

kenseii commented Nov 29, 2020

@spalger Hi! when it will happen? In docker hub there is only 7.9.3 and I go this issue

I am having the same error in the same version as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Operations Team label for Operations Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0
Projects
None yet
Development

No branches or pull requests